Description

I apologize for opening another issue about this but I really would like to see a properly working load condition for War Mode that is practically useable.

The "War Mode Active"/"Not War Mode Active" load condition is not behaving as I would expect it to.

Currently, this option checks if War Mode is "Active" by using the C_PvP.IsWarModeDesired() API

WeakAuras.lua line 1476

    warmodeActive = C_PvP.IsWarModeDesired();

Which means WA checks if you have "opted in" to War Mode - it doesn't care if War Mode is actually technically "enabled" or not. This is consistent with the War Mode button in the default UI. That button shows if you have opted in or not, even in Stormwind/Orgrimmar.

However, in Stormwind/Orgrimmar, if you toggle War Mode then auras with this load condition do not load/unload as you would expect them to. If you open WA's settings through /wa and then close them again, the auras do "update" and load/unload based on War Mode opt-in status.

In #3618 Infus says this is intended behavior. If that is the case, then WA should be using C_PVP.IsWarModeEnabled() instead of C_PvP.IsWarModeDesired() to check if War Mode is "enabled" or not.

I disagree that this is intended behavior. When opted in to War Mode in SW/Org you can use your War Mode abilities and you can absolutely PvP in those zones. I don't think WA should make some weird technical distinction when the game does not.

The event PLAYER_FLAGS_CHANGED can be use to detect when War Mode opt-in status changes.

Either way, I shouldn't have to open/close the options panel for my auras to update when using this load condition.

WeakAuras Version

3.7.16

World of Warcraft Flavor

Retail (Default)

Tested with only WeakAuras

• Yes
• No

Lua Error

No response

Reproduction Steps

1. Create an aura with the load condition "War Mode Active"
2. Go to Stormwind or Orgrimmar
3. Toggle War Mode and notice that the aura does not load/unload (nothing changes)
4. Open /wa and close it and notice that the aura does load/unload after closing the options window

Last Good Version

No response

Screenshots

No response

Export String

!WA:2!1r1YUTTruutOfbGTOWrOWiOnleAb6McKI0ayTwuLcXbQ2kK01UanLAiNljNgQzgmZqllVleDrx7FGcW1DL(eYIUMqOFb(tW5hi3ru2TOizfNh3hN75Cg6mP)I(0(0)4zkrLPKXb1jNgn9OJ9ByPcEOOsLcpEVGurPq9cNEo92OliuXYF(KSmnyE8ERj80cHAMGXnjJ9poYpytQquIXWdxYKWC5aktlljRIGlnXzc1cIjwgBylGD7CK7NwPnIf2iovsjgiaUa4M3ExL8P5qHNfsZRnkwEoO0F23O2T8V9mRKGxfNzK9R0qmjrlujphiL)OGcZVrxLSTEHvzzSlxhpEuyuCy0OGOB(3W3gA7N0mwWPmdtW13N3mfG5feoZF60ATeklpIQD7YTCjzL2OQWCFyIDmbvaNSa0U127TGAEdfsWwhHOu9C)PZMC60RR47qVR8HKud7ciQBVfh)1EYV8dYADlcSKh9wKYbfNu(tiBG4n)2xdGCeIVutabNGIR1qz2wPP9big0etLcj3cVmb3i3FIID1GxwrO4HKbrrn48ga52r)loOD)n42es6RZrVbNMuaS8cZB8kfe6epn7k4GGfvLgMBqAjrRpO97C9Sn3UiXqkrIZUS22Sqm8JQxku0Zuez9z7wSMX7MiSNU7SwN3zT61KEVq4Qw1DOJ8B)4Mj6kK3zPXMcfOlqJZQg12PXY7EgmH1)NKV9mIAGLRhmAl7)9vm6AXth(YH6HHJh(IBivOJerw6zmQPWBeU92oZ(efQV2IMeooW3)4asPSG0t(1FCSjvqkZks98Usiw4SbRowPtKDZN8ZVZPBZ9hyAssjqlu)g(SGLTYBQ)KOgJi9IoL(roZp)Ryuz)7NHiqBgmcvxL1lHL8WaTHOmUjzmotx46HFmURZSqp0yf8EblTd2BuxUJBtqcpJL7QyCBFGI7ORJWlEuV)8DR7eOXD)mWXPxd(QaOB5NF)tRVBekUMWzDA6HTNm5TarBBjWZnfpODFpUGdBOwNigrS9Pl2mRyRRTHAj22x5TGW4tA)fmH2x1(RTXTZXVZ()N0xN8SNm8jp9W(x8pN)(