WeakAuras

WeakAuras

206M Downloads

Miscellaneous 3 (Small UI issues)

Nightwarden24 opened this issue ยท 2 comments

commented

Description

The following are small issues mostly related to UI:

  1. Invalid atlas format here
    11
    It should be result = result .. "|A:" .. icon .. ":12:12:0:0|a" (see link)

  2. It seems you rushed to combine error messages like "Cannot hide secure frame..." and "Cannot show secure frame..." into one category (protected_frame) with warning messages in this commit. I mean error messages should have their own categories as it was before this change.

    As a result, at the current moment:
    a. "Cannot hide secure frame..." and "Cannot show secure frame..." messages are not shown on the Info tab and in the tooltip.
    b. In combat. If "Cannot show secure frame..." message is printed, then "Cannot hide secure frame..." message will never appear in the chat. And vice versa. Only one message is possible.

WeakAuras Version

4.0.1-4-ge274bda

World of Warcraft Flavor

Retail (Default)

Tested with only WeakAuras

  • Yes
  • No

Lua Error

-

Reproduction Steps

-

Last Good Version

No response

Screenshots

No response

Export String

No response

commented

By the way, if you are in combat and region is protected, then the following error pops up on Show:

Click me
1x [ADDON_ACTION_BLOCKED] AddOn 'WeakAuras' tried to call the protected function 'SetFrameLevel()'.
[string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519>
[string "=[C]"]: ?
[string "@WeakAuras\RegionTypes\Icon.lua"]:258: in function `SetFrameLevel'
[string "@WeakAuras\SubRegionTypes\Background.lua"]:14: in function `SetFrameLevel'
[string "@WeakAuras\WeakAuras-4.0.1-4-ge274bda.lua"]:3645: in function `ApplyFrameLevel'
[string "@WeakAuras\RegionTypes\RegionPrototype.lua"]:929: in function `Expand'
[string "@WeakAuras\WeakAuras-4.0.1-4-ge274bda.lua"]:3906: in function <WeakAuras\WeakAuras.lua:3900>
[string "@WeakAuras\WeakAuras-4.0.1-4-ge274bda.lua"]:3995: in function <WeakAuras\WeakAuras.lua:3957>
[string "@WeakAuras\WeakAuras-4.0.1-4-ge274bda.lua"]:4078: in function `UpdatedTriggerState'
[string "@WeakAuras\BuffTrigger2.lua"]:1616: in function <WeakAuras\BuffTrigger2.lua:1608>
[string "@WeakAuras\BuffTrigger2.lua"]:1952: in function <WeakAuras\BuffTrigger2.lua:1945>

It might also be worth checking to see if lockdown restrictions are currently in effect before calling this function.

commented

By the way, if you are in combat and region is protected, then the following error pops up on Show:
Click me

It might also be worth checking to see if lockdown restrictions are currently in effect before calling this function.

Yes I know I only made Show/Hide "safe". Making everything safe is not something I want to do. If someone creates protected frames, it'll break the addon.