WeakAuras

WeakAuras

200M Downloads

Custom Options bug when using arrays

Translitdk opened this issue ยท 3 comments

commented

Description

This error might happen if Option Type - Option Group was used and you delete one of the Sub Options
IMG

It bricks SavedVariables of given aura and prevent Author Options tab to be used

P.S. I've met this one long time ago and it doesn't matter WoW Flavor, but coulnd't reproduce before

WeakAuras Version

WeakAuras 5.4.2

World of Warcraft Flavor

Wrath of the Lich King Classic

Tested with only WeakAuras

  • Yes
  • No

Lua Error

https://i.imgur.com/DJK4Roi.png

Reproduction Steps

  1. Create any aura, go to the Custom Options tab and create Option Group with Array group type
  2. Now you have to add couple of Sub Options:
    • first one should be something that can't be used as Entry Name Source, for example Toggle
    • second one we use as the Entry Name Source, so we add "String" or "Number", and set it as source
    • delete first one and try to Enter User Mode > fatality

Error happens in this place IMG because when you remove one of the Sub Options SavedVariables have wrong nameSource
In my testing i had 3 Sub Options and deleted 1 of them. And this is how SavedVariables looked like: IMG
2 subOptions with nameSource of 3

Last Good Version

Screenshots

https://www.youtube.com/watch?v=sVdu6xneTfo

Export String

No response

commented

@emptyrivers Did that fix work if people had actually broken settings? It looked like it only fixed new cases of it?

commented

No no reports, except this one. I guess it's up to you to decide whether that's something that you can make more robust.

commented

oh, yeah i suppose there could be people with broken data. Do we have any reports of it?