WeakAuras

WeakAuras

200M Downloads

Static progress triggers probably shouldn't expose a "paused" property

emptyrivers opened this issue ยท 2 comments

commented

In 0e8d47f, a new common condition check 'Is Paused' was added:

paused = {
display =L["Is Paused"],
type = "bool",
test = function(state, needle)
return (state.paused and 1 or 0) == needle
end
},

The commit message suggests that this is supposed to be visible for any timed progress trigger, but it is also visible for static progress, e.g. Player/Unit Info -> Health.

It's minor, but was enough to trip me up when making a WA today. If it's simple to do, perhaps we should teach WeakAuras the difference between 'common' conditions, and 'common for timed progress' conditions.

commented

Doing so would possibly make TSU custom variables more complex to think about, which is the main reason I hesitate to say we need to do this.

commented

That's actually fixed in #4677