WeakAuras

WeakAuras

200M Downloads

WeakAuras doesn't abbreviate big numbers correctly in east asian client

Elnarfim opened this issue · 13 comments

commented

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

In East Asia counties, people use different numeral system to western countries (CN,KR,JP,TW)
reference - https://en.wikipedia.org/wiki/Korean_numerals
But WeakAuras is showing wrong number above 10k now
10k - 만(萬, 万) SECOND_NUMBER as GlobalString
100m - 억(億, 亿) THIRD_NUMBER as GlobalString
1000b - 조(兆) FOURTH_NUMBER as GlobalString
East asian uses that instead million and billion
WeakAuras is calculating 10m as 억(億, 亿) now. 10k is working correctly

WeakAuras Version

5.8.7

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

TW/Asia

Tested with only WeakAuras

  • Yes

Lua Error

No response

Reproduction Steps

Use big number for number format in east asian client such as CN,TW,KR

Last Good Version

Never

Screenshots

No response

Export String

No response

commented

Plater shows numbers correctly. for example: Tindral supernova's shield numbers

commented

I'm not interested in other addons, I'm interested n the base game. Also please add the output of /dump AbbreviateNumbers(10000000) to the ticket.

commented

and it should not be space between number and text like '1억' '1만'

commented

it shows incorrect format. maybe blizz bug

commented

Right, how does /dump AbbreviateLargeNumbers(10000000) look like?

commented

It shows 1억 now

commented

How about add custom function instead blizzard. I think KR client has the bug only

commented

That's incorrect right, it should be 1000 만?

commented

right. it shoud be 1000만

commented

also you have to check other asian clients such as TW, CN

commented

CN doesn't exist anymore, though JP has the same system. We'll check before deciding what we should do.

commented

There's apparently no JP-client, and the CN client can connect to TW servers.

The bug is indeed in blizzard's code, more details at Stanzilla/WoWUIBugs#515

Now we have to decide what WA should do about that.

commented

Those number formats use blizzard functions, that is AbbreviateLargeNumbers and AbbreviateNumbers.

Thus I would expect /dump AbbreviateNumbers(10000000) to show an incorrect formatting too.

Does the game display those numbers correctly formatted anywhere?