WeakAuras

WeakAuras

Addons
206M Downloads

Lua errors since 5.12.1

Iceacm opened this issue ยท 4 comments

commented

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

Since WA 5.12.1 i'm getting numerous lua errors
Rolling back to 5.12.0 fixes the issue, no lua errors

WeakAuras Version

5.12.1

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

EU

Tested with only WeakAuras

  • Yes

Lua Error

10x WeakAuras/RegionTypes/DynamicGroup.lua:1350: attempt to index local 'controlPoint' (a nil value)
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1350: in function `DoPositionChildrenPerFrame'
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1513: in function `DoPositionChildren'
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1329: in function `PositionChildren'
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1310: in function `SortUpdatedChildren'
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1198: in function `ReloadControlledChildren'
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1107: in function `RunDelayedActions'
[string "@WeakAuras/WeakAuras.lua"]:1271: in function <WeakAuras/WeakAuras.lua:1211>

[string "@WeakAuras/WeakAuras.lua"]:1370: in function <WeakAuras/WeakAuras.lua:1318>

Locals:
self = Frame {
 0 = <userdata>
}
event = "PLAYER_LOGIN"
addon = nil
dbIsValid = true
takeNewSnapshots = nil
ADDON_NAME = "WeakAuras"
db = <table> {
 editor_tab_spaces = 4
 displays = <table> {
 }
 minimap = <table> {
 }
 historyCutoff = 730
 dbVersion = 71
 clearOldHistory = 30
 editor_theme = "Monokai"
 dynamicIconCache = <table> {
 }
 editor_font_size = 12
 RealTimeProfilingWindow = <table> {
 }
 registered = <table> {
 }
 lastUpgrade = 1710876878
 personalRessourceDisplayFrame = <table> {
 }
 migrationCutoff = 730
 features = <table> {
 }
 login_squelch_time = 10
 lastArchiveClear = 1580751128
 ProfilingWindow = <table> {
 }
}
Private = <table> {
 HandleGlowAction = <function> defined @WeakAuras/WeakAuras.lua:3601
 frame_strata_types = <table> {
 }
 DisplayToString = <function> defined @WeakAuras/Transmission.lua:354
 combat_event_type = <table> {
 }
 regions = <table> {
 }
 frameLevels = <table> {
 }
 CheckItemSlotCooldowns = <function> defined @WeakAuras/GenericTrigger.lua:3011
 InitializeEncounterAndZoneLists = <function> defined @WeakAuras/Types_Retail.lua:10
 IsEnvironmentInitialized = <function> defined @WeakAuras/AuraEnvironment.lua:185
 duration_types = <table> {
 }
 CleanArchive = <function> defined @WeakAuras/History.lua:22
 UpdateProgressFrom = <function> defined @WeakAuras/RegionTypes/RegionPrototype.lua:558
 RunConditions = <function> defined @WeakAuras/Conditions.lua:838
 tooltip_count = <table> {
 }
 SmoothStatusBarMixin = <table> {
 }
 pet_spec_types = <table> {
 }
 regionOptions = <table> {
 }
 get_zoneId_list = <function> defined @WeakAuras/Types_Retail.lua:72
 checkForSingleLoadCondition = <function> defined @WeakAuras/Prototypes.lua:1156
 author_option_classes = <table> {
 }
 grid_types = <table> {
 }
 non_transmissable_fields = <table> {
 }
 absorb_modes = <table> {
 }
 combatlog_spell_school_types_for_ui = <table> {
 }
 miss_types = <table> {
 }
 CancelDelayedTrigger = <function> defined @WeakAuras/GenericTrigger.lua:905
 centered_types_h = <table> {
 }
 ensurePRDFrame = <function> defined @WeakAuras/WeakAuras.lua:5400
 talent_types = <table> {
 }
 LoadFunction = <function> defined @WeakAuras/AuraEnvironment.lua:637
 reset_swing_spells = <table> {
 }
 spec_types_all = <table> {
 }
 player_target_events = <table> {
 }
 GetTalentData = <function> defined @WeakAuras/Types_Retail.lua:185
 subRegionTypes = <table> {
 }
 UnregisterAllEveryFrameUpdate = <function> defined @WeakAuras/GenericTrigger.lua:1837
 array_entry_name_types = <table> {
 }
 combatlog_spell_school_types = <table> {
 }
 StringToTable = <function> defined @WeakAuras/Transmission.lua:298
 RegisterLoadEvents = <function> defined @WeakAuras/WeakAuras.lua:1889
 GetReputationsSorted = <function> defined @WeakAuras/Types.lua:1723
 blend_types = <table> {
 }
 text_automatic_width = <table> {
 }
 EnforceSubregionExists = <function> defined @WeakAuras/RegionTypes/RegionPrototype.lua:1115
 CheckSpellCooldown = <function> defined @WeakAuras/GenericTrigger.lua:2883
 custom_trigger_types = <table> {
 }
 group_types = <table> {
 }
 subRegionOptions = <table> {
 }
 GetProgressValueConstant = <function> defined @WeakAuras/WeakAuras.lua:3907
 text_rotate_types = <table> {
 }
 spec_types = <table> {
 }
 anim_ease_types = <table> {
 }
 item_slot_types = <table> {
 }
 multiUnitUnits = <table> {
 }
 anim_color_types = <table> {
 }
 loaded = <table> {
 }
 Convert = <function> defined @WeakAuras/WeakAuras.lua:2259
 sound_channel_types = <table> {
 }
 CheckCooldownReady = <function> defined @WeakAuras/GenericTrigger.lua:3070
 event_prototypes = <table> {
 }
 NeedToRepairDatabase = <function> defined @WeakAuras/WeakAuras.lua:2336
 AtlasList = <table> {
 }
 R

Reproduction Steps

Errors starts at login

Last Good Version

5.12.0

Screenshots

5 12 1
5 12 0

Export String

No response

commented

reverting d08c42b fix issue

commented


WeakAuras.zip

commented

I can reproduce error when login on a DH with the data

1st error:

1x WeakAuras/RegionTypes/DynamicGroup.lua:1350: attempt to index local 'controlPoint' (a nil value)
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1350: in function `DoPositionChildrenPerFrame'
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1513: in function `DoPositionChildren'
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1329: in function `PositionChildren'
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1310: in function `SortUpdatedChildren'
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1198: in function `ReloadControlledChildren'
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1107: in function `RunDelayedActions'
[string "@WeakAuras/WeakAuras.lua"]:1271: in function <WeakAuras/WeakAuras.lua:1211>

[string "@WeakAuras/WeakAuras.lua"]:1370: in function <WeakAuras/WeakAuras.lua:1318>

2nd error

14x WeakAuras/RegionTypes/DynamicGroup.lua:1350: attempt to index local 'controlPoint' (a nil value)
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1350: in function `DoPositionChildrenPerFrame'
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1513: in function `DoPositionChildren'
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1329: in function `PositionChildren'
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1310: in function `SortUpdatedChildren'
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1110: in function `RunDelayedActions'
[string "@WeakAuras/RegionTypes/DynamicGroup.lua"]:1101: in function `Resume'
[string "@WeakAuras/WeakAuras.lua"]:4651: in function <WeakAuras/WeakAuras.lua:4611>
[string "@WeakAuras/WeakAuras.lua"]:4776: in function `UpdatedTriggerState'
[string "@WeakAuras/GenericTrigger.lua"]:841: in function `ScanUnitEvents'
[string "@WeakAuras/GenericTrigger.lua"]:1122: in function <WeakAuras/GenericTrigger.lua:1118>
commented

If i add before error

      if controlPoint == nil then
        print("regionData.id", regionData.id, "region.id", region.id)
      end

it fail on DPS Potion for group Utility Bar

Utility Bar use a custom sort function

function(a, b)
    local list = list or ""
    if list == "" then
        list = {
            ["DPS Potion"] = 1,
            ["Mana Potion"] = 1,
            ["Health Potion"] = 2,
            ["Healthstone"] = 3,
            ["Cloak Enchant"] = 4,
            ["Belt Enchant"] = 5,
            ["Undulating Sporecloak"] = 4,
            ["Demonic Gateway"] = 5,
        }
    end
    
    if list[a.id] then 
        if list[b.id] then
            return list[a.id] < list[b.id]
        else
            return true
        end
    elseif list[b.id] then 
        return false
    else
        return a.region.state.expirationTime > b.region.state.expirationTime
    end
end

If i rollback to 5.12.0, set sorting for this group to none and go back to 5.12.1 error is gone