WeakAuras

WeakAuras

209M Downloads

Allow Charges/Stacks Count Condition for Weapon Enchant Trigger (e.g. Rogue Poisons)

RadicalRoy opened this issue ยท 6 comments

commented

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

Bugs:

  1. Enabling a Condition for remaining stacks of a Weapon Enchant trigger is not an option in the list. I believe this is a bug because "Remaining duration" is an option in this list and they shouldn't be notably different
    image

  2. Another bug I noticed when I was also able to create a Trigger for Deadly Poison III with a Stack Count toggled... but it seems this property is completely ignored and does not actually affect the trigger. [626 is the id for the Deadly Poison III (rank 3) item effect]
    image

My guess is some conflating of "stacks" and "charges". For instance, Combustion will gain "stacks" as a fire mage casts spells and increase the counter on the buff. Poisons however do not use "stacks" in the traditional sense but rather "charges": these do not show a counter unless you mouse over the buff icon.

My ideal scenario is to specify a Condition for when the Stack/Charges Count < 30 to display the Pixel Glow alerting me to refresh my poison charges.

Please fix the above so that Rogues can use the Stack Count option for poison charges. Thank you

WeakAuras Version

WeakAuras 5.12.8

World of Warcraft Flavor

Classic

World of Warcraft Region

US/NA

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error

No response

Reproduction Steps

  1. Create Icon WeakAura
  2. Set Trigger for Item > Weapon Enchant > Offhand
  3. Specify Weapon Enchant 626 (Deadly Poison III)
  4. Specify Show On > Enchant Found
  5. Using Deadly Poison III on Offhand now correctly displays the icon
  6. Bug 2 from description: Setting Trigger "Stack Count" with any <, >, <=, >=, =, != symbols and any number does not affect the Icon displaying. It will always show (even if you put Stack Count < 0 as in the screenshot).
  7. Bug 1 from description: Further, there is no option in the drop down when creating a Condition for the Weapon Enchant Trigger to select the Stack Count as an option

Last Good Version

No response

Screenshots

No response

Export String

No response

Bisector Report

No response

commented

I don't have a rogue to check, so can you run this command in chat: "/dump GetWeaponEnchantInfo()", and make a screenshot of the output?

commented

That looks correct, what does /dump WeakAuras.GetOHTenchInfo() return?

commented

As requested @InfusOnWoW
I used Crippling Poison II Mainhand and Deadly Poison III Offhand (Crippling does not use charges)
image

commented

Here's the result of that command
image

commented

I will add that thanks to your pointing out these methods ๐Ÿ™ , I've managed to implement my desired condition using custom code:
image

I spent some time looking through the Lua code in this repo and I think the Stack Count check is just missing for the weapon enchant trigger (should be around the remaining or triggerRemaining comparisons in Prototypes.lua near line 7227). Though I'm admittedly not very proficient in Lua code.

commented

Confirmed the fix is working for the trigger, and the condition option! Thank you @InfusOnWoW ๐Ÿ™