WeakAuras

WeakAuras

Addons
200M Downloads

WeakAuras.CheckTalentForUnit in LibSpecializationWrapper not working on TWW

Jodsderechte opened this issue ยท 1 comments

commented

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

I know this is an internal function that is not even used internally (yet). But i tried around a bit on beta and found some errors happening wanted to atleast document them. I also tried to fix them myself but got stuck halfway through :D From my findings TWW no longer uses serializationVersion 1 but instead uses serializationVersion 2 and correspondingly some changes to different parts. From my findings it seems to be that the figuring out of unselected choice nodes isn't working correctly.

WeakAuras Version

5.14.0-1-g27e2212

World of Warcraft Flavor

Beta (WoW 11.0)

World of Warcraft Region

EU

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error

Changin the serialization check i can produce this error but not like it matters

WeakAuras/LibSpecializationWrapper.lua:203: attempt to index local 'unselctedTalentData' (a nil value)
[string "@WeakAuras/LibSpecializationWrapper.lua"]:203: in function `CheckTalentForUnit'
[string "return "]:6: in function <[string "return "]:2>
[string "=[C]"]: in function `xpcall'
[string "@WeakAuras/GenericTrigger.lua"]:644: in function <WeakAuras/GenericTrigger.lua:629>
[string "@WeakAuras/GenericTrigger.lua"]:901: in function `ScanEventsInternal'
[string "@WeakAuras/GenericTrigger.lua"]:846: in function `ScanEvents'
[string "return function() "]:11: in function `func'
[string "@WeakAuras/Libs/LibSpecialization-10/LibSpecialization.lua"]:343: in function <...akAuras/Libs/LibSpecialization/LibSpecialization.lua:317>

Reproduction Steps

  1. uncomment the serializationVersion (or don't and you get nil all the time)
  2. run WeakAuras.CheckTalentForUnit(unit, 90783) and get an error or nil depending on if you adjusted the serializationVersion

Last Good Version

No response

Screenshots

No response

Export String

No response

Bisector Report

No response

commented

The error i mentioned in the previous ticket is still happening. I tried botht he alpha version aswell as manually copy pasting your changes just to be 100% sure

1x Lua error in aura 'Interrupt Tracker Bar new': Trigger 1 WeakAuras Version: 5.14.1-5-gd8444f2 Aura Version: 1.0.68 WeakAuras/LibSpecializationWrapper.lua:229: attempt to index local 'unselctedTalentData' (a nil value) [string "@WeakAuras/LibSpecializationWrapper.lua"]:229: in function CheckTalentForUnit'
[string "return "]:51: in function <[string "return "]:2>
[string "=[C]"]: in function xpcall' [string "@WeakAuras/GenericTrigger.lua"]:644: in function <WeakAuras/GenericTrigger.lua:629> [string "@WeakAuras/GenericTrigger.lua"]:901: in function ScanEventsInternal'
[string "@WeakAuras/GenericTrigger.lua"]:846: in function ScanEvents' [string "return function() aura_env.InspectList = {}"]:8: in function func'
[string "@WeakAuras/Libs/LibSpecialization-10/LibSpecialization.lua"]:343: in function <...akAuras/Libs/LibSpecialization/LibSpecialization.lua:317>`