WeakAuras

WeakAuras

200M Downloads

"Charge gained/lost" with "Gained" and "Lost" triggers error

linaori opened this issue ยท 1 comments

commented

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

This setting will trigger and error when "Trigger -> Spell -> Charges Changed Event -> Charge gained/lost -> Gained/Lost" is being used and you open the WA in the options. I could only recreate this on a spec that didn't have the spell. Example: On havoc DH this does not error when checking for Fel Rush, but it breaks on other characters.

WeakAuras Version

5.15.4

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

EU

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error

9x Lua error in aura 'Trigger bug on charges gained/lost': Trigger 1
WeakAuras Version: 5.15.4
WeakAuras/Prototypes.lua:992: attempt to compare number with nil
[string "@WeakAuras/Prototypes.lua"]:992: in function `CheckChargesDirection'
[string ""]:15: in function <[string ""]:2>
[string "=[C]"]: in function `xpcall'
[string "@WeakAuras/GenericTrigger.lua"]:702: in function <WeakAuras/GenericTrigger.lua:625>
[string "@WeakAuras/GenericTrigger.lua"]:1056: in function `CreateFakeStates'
[string "@WeakAuras/WeakAuras.lua"]:4523: in function `UpdateFakeStatesFor'
[string "@WeakAuras/WeakAuras.lua"]:4499: in function `FakeStatesFor'
[string "@WeakAuras/WeakAuras.lua"]:3191: in function <WeakAuras/WeakAuras.lua:3046>
[string "@WeakAuras/WeakAuras.lua"]:3215: in function `Add'
[string "@WeakAuras/WeakAuras.lua"]:2295: in function `Rename'
[string "@WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua"]:796: in function <...eGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:792>
[string "@WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua"]:1299: in function `func'
[string "@WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua"]:1843: in function <...eGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1837>

Locals:
direction = nil
triggerDirection = "GAINED"
(*temporary) = nil
(*temporary) = "attempt to compare number with nil"

Reproduction Steps

  1. Import the WA
  2. Open it in the settings

Last Good Version

Not 100% sure, haven't clicked this WA for a while

Screenshots

image

Export String

!WA:2!DvvSUTXrqurXGyaIGajgzdzaxqy4yeKcLyJibKueaE0KwkGIu(4PyNkE7D3W724J7UE39OevNzLQzt6zDcqa)e0xWbI8fWI8bOYuLzxEK2YQG3mZo7mVzM3oQuRQdRgvn66VzgnKZ6XZKHWJ2Aoj63ZuAi6uYLB)bfkBB54UdgOaDP5ewycxEgNY0bnA2XRP7IqopnIFbR3fub4FZA1MrXqIKeQPCM6ixLMi1vCOmQUsWa8JkPYeTKghds1x(uzH413FAevc2Bf8Y6N0P5le7MPG(XadK0WEj8l6Y8xCh1Lk7Ngfz2LrgcQklmxBtW8NQeqAAh8O93()2sStycrgdQ(CbijAUS6p7OhlaxRBIQMltcuCzWXaj9uEe4VuLfaJaMUx2Gb0lN3Vr9EE975v31BUX9IiM4AD62gRuRHFzXq0YperB0KfUx9zwGUbD(tSINePQSjHNjbmHU9oRz72ozylmqKsgdYjMBA09NAK0y7(T(ZIGaeGEyXipUz7ZADE7PzSI(BfXUMrYiWBLUbk)5w3IJtqYiP)komWM1FSui5XsqPwXn(2hT12tvq6a7Gp)ZXuOi6mSVbjZqq6cXMP8p9G89xGQbimIL8mw017jQQHl19vjeC08McAK4HwJ2FgWLdjOdfcomodMU54h)1kXoFueAWt5YFPuPsLxUY6Aq5u)CVUIVYAKKP5yOOHVMgPtCQJQ3Ukx0lHiRX3Vyft(3kq0n2ZnmE6GXybk5AS48qJoD62Pz((sSUm(mZ6yOfgLX)MwuemTyNws6v1EvgjcBmKAEE3P2xNPfwBxWLrVwsetEDHWkamIQObPGFrn)rV2e7EsNonD7701ZR7PUN8YJ9wSj19OxbpSOIEZDYJ5ultO75ETXxt)7I4u(fTKW7Yaw44Z(SV)GNF4QQZCWnMFEHzWIZZYtmAMBViitR5SUJajY7Mzm3gyX6K7p3iVU0MAuASP1CdYjF5AljwpxdohJsI1)EHKuOSfwEj0W3Yqwxz7jTPO8U2S5GDjqMeKa04e97Ds5KObldtjkf2KImVEcFAGIYItH9EI7WSun9b79e)angCM(b5HvSVqy4ZjzIJXDJnxBemsokSfAee7G(vVy3NDvyYNAIYsMjTmEtVXXSc1LKksiLNsy0H2E3r5vALVF(r3aef0tlTDR7TiQO123SQrQa8QrQjgFmHk)iNHekZEXC(9Yf5VlxIIFXNAzY6LS(I9wlA4QVGQii9jk523cGOUPm1UMeM4(bgRZvC(WsbyQhqJRmtZdhT6v)(L(R)(X0iXJl2nulilUgNvRyrvTyeBq03LYvA3lSpIMpqIBSWYd57LVDf)RLXKPAc61WTzZo2vPRxnJRBq8a(ppJgn)DTE1jJo(ewWpowszgqajlW3Uyq6kS)BJk5P(Zm9i6k15u2QTeOwf5LfKPQQGdp4zhEWpuD0)8M))p

Bisector Report

No response

commented

That appears to be already fixed as an side effect of recent changes to how we track spells. I can reproduce a lua error with 5.15.4, but not with the changes for the next release.