WeakAurasAbramsBug.zip

Is there an existing issue for this?

• I have searched the existing open and closed issues.

Description

Since the last patch every version of WAs has been missing the "Add New" and "search" feature in the WA UI window. Currently using "5.17.1-34-g514f3b4" and the bug still persists. I disabled all addons except WAs and buggrabber/bugsack and I get a "green" no bugs result until I open WAs where then it generates the error in the attached photo.

WeakAuras Version

5.17.1-34-g514f3b4

World of Warcraft Flavor

Classic Era

World of Warcraft Region

US/NA

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error

5x WeakAuras/GenericTrigger.lua:3451: Usage: FindSpellOverrideByID(spellID)
[string "=[C]"]: ?
[string "@WeakAuras/GenericTrigger.lua"]:3451: in function `GetEffectiveSpellId'
[string "@WeakAuras/Prototypes.lua"]:2247: in function `GetNameAndIcon'
[string "@WeakAuras/GenericTrigger.lua"]:1064: in function <WeakAuras/GenericTrigger.lua:1050>
[string "@WeakAuras/GenericTrigger.lua"]:1100: in function `CreateFakeStates'
[string "@WeakAuras/WeakAuras.lua"]:4598: in function `UpdateFakeStatesFor'
[string "@WeakAuras/WeakAuras.lua"]:4574: in function `FakeStatesFor'
[string "@WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua"]:1545: in function `SyncVisibility'
[string "@WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua"]:1571: in function `PriorityShow'
[string "@WeakAurasOptions/WeakAurasOptions.lua"]:730: in function <WeakAurasOptions/WeakAurasOptions.lua:699>

[string "@WeakAuras/WeakAuras.lua"]:4458: in function <WeakAuras/WeakAuras.lua:4455>

Locals:
start = 48125288.850700
threads = <table> {
 pools = <table> {
 }
 frame = Frame {
 }
 prios = <table> {
 }
 size = 3
}

Reproduction Steps

Click on WAs options to load the options UI to create or edit WAs and the error happens.

Last Good Version

No response

Screenshots

Export String

No response

Bisector Report

No response

We need your settings to reproduce that.

Which settings specifically. WeakAurasOptions?

No, the WeakAuras.lua file, the initial bug template asked you to include.

We need your settings to reproduce that.

they put it at the very top in a later edit

No, the WeakAuras.lua file, the initial bug template asked you to include

I added a .zip file. Looks like it appears at the top of the post on my screen.

I dont have a warrior, but i can reproduce by clicking the visibility button for unloaded auras

Error happen when Private.ExecEnv.GetEffectiveSpellId which call GetOverrideSpell which is FindSpellOverrideByID, is called with a string "Victory Rush", instead of a number

data from trigger making error

  ["trigger"] = {
    ["duration"] = "0",
    ["genericShowOn"] = "showOnCooldown",
    ["unit"] = "player",
    ["use_direction"] = true,
    ["debuffType"] = "HELPFUL",
    ["use_sourceName"] = false,
    ["subeventSuffix"] = "_CAST_SUCCESS",
    ["use_genericShowOn"] = true,
    ["event"] = "Action Usable",
    ["use_sourceFlags2"] = false,
    ["realSpellName"] = "Victory Rush",
    ["use_spellName"] = true,
    ["sourceUnit"] = "player",
    ["use_sourceUnit"] = true,
    ["type"] = "spell",
    ["subeventPrefix"] = "SPELL",
    ["use_track"] = true,
    ["spellName"] = "Victory Rush"
  }

AddFakeInformation
=> GetNameAndIconForSpellName(trigger)
=> Private.ExecEnv.GetEffectiveSpellId(trigger.spellName, trigger.use_exact_spellName, not trigger.use_ignoreoverride)
=> FindSpellOverrideByID("Victory Rush")

Yeah I have a fix, I was assuming only numbers in the spell field, which turns out to be wrong in pratice.