Idea: Default Values
Stanzilla opened this issue · 8 comments
Just need to write this down before I forget, will fill in further ideas etc later:
Default settings so auras are always created with the font, texture etc you want. All options would be set to "your defaults" by default (...)
idea dump:
when a value of an option is overriden by a default user value, re-use the same system that colors things blue in groups but make it green
Yes exactly, like this:
Then on this page, every region type would be represented by a tab where you can set default fonts, font sizes, bar textures etc.
A bit of information on a way to achieve this:
In each regionTypes file, there is a table at the top called defaults. When a new region is created, it is populated with data that originates from this table.
Add a collection to the WeakAuras database (db.regionDefaults or similar). In RegisterRegionType, add the defaults provided to this collection, indexed by regionType. Do this as an upsert (i.e. only add new default values, don't modify existing ones), so that we can add new data to region Defaults without having to modernize the regionDefaults collection except in semi-rare cases. Then, when a new aura is created (via New, Duplicate, Templates, Conversion, etc), pull defaults from this collection instead of from the region defaults.
Create a new option somewhere in WeakAurasOptions which will create dummy options. We could use the a similar hack to what WeakAuras.tempGroup employs to get the options to show up. When these fake options are edited, modify the regionDefaults collection accordingly.
Just to keep this up to date, @emptyrivers suggested this being more akin to a Themes setting, which means we could allow users to have more than one and let them share them eventually.
Couple weeks ago did some work on this. Got about this far https://streamable.com/mmus84 . Since then have kind lost interest and not sure if I would continue on this, so posting here my branch with the code changes just in case anyone wants to continue or take a look at what I did.
https://github.com/sragia/WeakAuras2/commit/c6ef8d39801187c59e25655e9bfc368a6a09ca50
https://github.com/sragia/WeakAuras2/commit/3a9610a45d1bf7b68bab4370c6cdcf5e6025a866
Do not guarantee good code or if things were done properly, this was just an evening project without very big understanding how wa options work.
we need this! mass editing fonts etc is still slow/stuttery in larger groups.
especially for slider related stuff like text size. (unless you input the value directly)
the group scale thing got popular real fast for this reason
I'd also suggest adding a dropdown menu with the currently specified sound channels and an option to set it to 128. (custom)
It's a big issue that causes sounds to cut off when many sounds are played simultaneously which happens real fast if people have combat sound enabled.
blizzard only offers up to 64 sound channels, setting it higher displays it as "custom"
it tends to cut off sharedmedia sounds etc.
