[Cata Classic] Options panel errors after 4.4.1

Question

[Cata Classic] Options panel errors after 4.4.1

Road-block opened this issue 2 months ago · 8 comments

Road-block commented 2 months ago

Fix(es)

Replace instances of

        InterfaceOptionsFrame_OpenToCategory("WeaponSwingTimer")
        InterfaceOptionsFrame_OpenToCategory("WeaponSwingTimer")

with

if _G.InterfaceOptionsFrame_OpenToCategory then
    InterfaceOptionsFrame_OpenToCategory("WeaponSwingTimer")
    InterfaceOptionsFrame_OpenToCategory("WeaponSwingTimer")
elseif Settings and Settings.OpenToCategory then
    Settings.OpenToCategory(addon_data.options_category.ID)
end

(one in the slash handler)

Replace instances of

InterfaceOptions_AddCategory(<blah>)

with respectively (main category, melee, hunter)

if _G.InterfaceOptions_AddCategory then
    InterfaceOptions_AddCategory(panel)
elseif Settings and Settings.RegisterCanvasLayoutCategory then
    panel.OnDefault = panel.default
    local cat = Settings.RegisterCanvasLayoutCategory(panel, panel.name)
    cat.ID = panel.name
    Settings.RegisterAddOnCategory(cat)
    addon_data.options_category = cat
end

if _G.InterfaceOptions_AddCategory then
    InterfaceOptions_AddCategory(panel.config_melee_panel)
elseif Settings and Settings.RegisterCanvasLayoutSubcategory then
    panel.config_melee_panel.OnDefault = panel.default
    local subCat = Settings.RegisterCanvasLayoutSubcategory(addon_data.options_category, panel.config_melee_panel, panel.config_melee_panel.name)
end

    if _G.InterfaceOptions_AddCategory then
        InterfaceOptions_AddCategory(panel.config_hunter_panel)
    elseif Settings and Settings.RegisterCanvasLayoutSubcategory then
        panel.config_hunter_panel.OnDefault = panel.default
        local subCat = Settings.RegisterCanvasLayoutSubcategory(addon_data.options_category, panel.config_hunter_panel, panel.config_hunter_panel.name)
    end

(three places in _Config.lua)

Road-block · Answer 1 · 2024-10-30T11:37:36.000Z

This would probably also fix similar errors in 1.15.4.

rbpaiett · Answer 2 · 2024-11-09T22:13:14.000Z

Probably not since there's no 'interfaceoptions' anywhere in Options.lua.

Road-block · Answer 3 · 2024-11-10T01:31:11.000Z

Probably not since there's no 'interfaceoptions' anywhere in Options.lua.

I don't think you understand the code.
The conditionals ensure that InterfaceOptions methods are only used if they exist on the client.
If they don't the modern Settings API is used.

rbpaiett · Answer 4 · 2024-11-10T06:15:34.000Z

The very first line states to replace:

    InterfaceOptionsFrame_OpenToCategory("WeaponSwingTimer")
    InterfaceOptionsFrame_OpenToCategory("WeaponSwingTimer")

If those two lines don't exist in Classic Era's Config.lua, what will I be replacing instead?

UPDATE:

Oh I get it, nm, lol.

Road-block · Answer 5 · 2024-11-10T23:17:52.000Z

For folks that are not comfortable doing source edits, here's a test package.
WeaponSwingTimer-test-fix.zip

I know it works in Cata Classic, haven't tested Vanilla flavors but if the errors are options related it will likely work there as well.

rbpaiett · Answer 6 · 2024-11-11T09:43:11.000Z

Actually, the latest version as it stands does work for Classic Era.

G333h · Answer 7 · 2024-11-15T09:19:45.000Z

wow I was looking for that, amazing THANKS so much !

Road-block · Answer 8 · 2024-11-20T17:30:08.000Z

Last push seems to have a applied a similar fix.

Share to