Artisan's Consortium rep not working.

Question

Artisan's Consortium rep not working.

SiJiL82 opened this issue 2 years ago · 13 comments

SiJiL82 commented 2 years ago

When I gain Artisan's Consortium rep, WonderRep logs out " WonderRep: 0 reputation with Artisan's Consortium - Dragon Isles Branch needed for Revered. (1 reputation gains left) A total of 835 reputation gained this session. estimated time to Revered. "

SiJiL82 · Answer 1 · 2024-02-15T14:05:25.000Z

Just added this to enUS.lua

-- Glimmerogg Racer
L["Aspirational"] = true        --    0 -  700
L["Amateur"] = true             --  700 - 1400
L["Competent"] = true           -- 1400 - 2100
L["Skilled"] = true             -- 2100 - 2800
L["Professional"] = true        -- 2800+

and tested by doing a daily:

So looks like each individual rep with different names needs adding :(

I'll create a fork and go through all the ones they've added that are like this over the weekend and send over a PR for you.

nawglan · Answer 2 · 2024-02-17T14:17:24.000Z

awesome. thanks for helping debug. 8) I'll work on adding all of those.

nawglan · Answer 3 · 2024-02-17T15:57:15.000Z

there is more to do than just adding the strings to the localization files. and looking at this spaghetti code, it really needs refactored. 8/

Thanks for offering to do a PR.

nawglan · Answer 4 · 2024-02-19T14:47:38.000Z

how's v2.2.4 working out for yall?

SiJiL82 · Answer 5 · 2024-02-19T17:44:59.000Z

how's v2.2.4 working out for yall?

Just tested with Azerothian Archives and Glimmerogg Racer reps, both working perfectly

Thanks very much!

nawglan · Answer 6 · 2024-02-19T19:01:28.000Z

Glad to hear it! Closing this. /fingers-crossed 8)

nawglan · Answer 7 · 2024-02-02T00:47:58.000Z

sorry this went unanswered for so long. I can only think that it could be because that rep was minimized / collapsed in the reputation window. There isn't anything in the code that would prevent it from working other than being impacted by what is collapsed in the rep window.

nawglan · Answer 8 · 2024-02-02T00:48:43.000Z

closing request.

SiJiL82 · Answer 9 · 2024-02-02T21:43:24.000Z

The same thing happens with the new Azerothian Archives rep.

It's not minimised in the reputation window:

nawglan · Answer 10 · 2024-02-04T18:01:39.000Z

Thanks, reopened the ticket. I have been playing classic lately, will start a character on retail to see if I can reproduce.

nawglan · Answer 11 · 2024-02-15T01:00:59.000Z

What are the different ranks that are possible? It could be that I'm just missing those. found it.
1 | Neutral | 0 | 500
2 | Preferred | 500 | 2000
3 | Respected | 2500 | 3000
4 | Valued | 5500 | 7000
5 | Esteemed | 12500

nawglan · Answer 12 · 2024-02-15T01:15:41.000Z

hopefully adding those will fix the issue.

SiJiL82 · Answer 13 · 2024-02-15T13:50:48.000Z

Unfortunately not

If what you posted before is what needs adding, it might be because they seem to have given all these reps different names for each level...

Azerothian Archives has

Soridormi has

Glimmerogg Racer has

So you probably have fixed it for Artisan's Consortium (I can't test it any more, I'm at max rep!) but looks like it might need individual updates for every other faction that uses this format?

Share to