Waypoint issue.
ndlarsen opened this issue ยท 17 comments
Hi.
I get this error every once in a while when WoWPro needs to set a new waypoint.
Additionally, the guide text usually lacks coordinates. Example from the dragonblight guide: "Face south, then stay left, he's in a small hut at ."
Error occured in: Global
Count: 1
Message: ..\AddOns\TomTom\TomTom.lua line 786: attempt to perform arithmetic on local 'x' (a string value)
Debug:
[C]: ?
TomTom\TomTom.lua:786: AddZWaypoint()
WoWPro\WoWPro_Mapping.lua:38: MapPoint()
WoWPro\WoWPro_Broker.lua:155: CompleteStep()
...ce\AddOns\WoWPro_Leveling\WoWPro_Leveling_Parser.lua:410: AutoCompleteQuestUpdate()
...ce\AddOns\WoWPro_Leveling\WoWPro_Leveling_Parser.lua:298: EventHandler()
WoWPro\WoWPro_Broker.lua:140:
WoWPro\WoWPro_Broker.lua:121
WoWPro, v1.0.0
WoWProLeveling, v1.0.0
TomTom, vwowi:revision (that being r240)
Gross, will look into it, thanks. Is it every waypoint?
Also, the lack of coordinates in step notes is intended. There will, in the future, be a way to view listed coordinates.
Hi.
Cool, sounds good.
No, it is far from every time I get the error, I haven't seen it today. It seem sort of random. I have, however, completely removed the WoWPro and TomTom folders and added them again today. Unable to say so far if this is related.
Okay. Let me know next time you get it, the specific step and guide. Then I can see what in the guide file might be causing it. Thanks :)
Hi again.
Had it again today when accepting the dragonblight quest "Do Unto Others".
Date: 2010-08-08 10:16:40
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\TomTom\TomTom.lua line 786: attempt to perform arithmetic on local 'x' (a string value)
Debug:
[C]: ?
TomTom\TomTom.lua:786: AddZWaypoint()
WoWPro\WoWPro_Mapping.lua:38: MapPoint()
WoWPro\WoWPro_Broker.lua:155: CompleteStep()
...ce\AddOns\WoWPro_Leveling\WoWPro_Leveling_Parser.lua:410: AutoCompleteQuestUpdate()
...ce\AddOns\WoWPro_Leveling\WoWPro_Leveling_Parser.lua:298: EventHandler()
WoWPro\WoWPro_Broker.lua:140:
WoWPro\WoWPro_Broker.lua:121
No. The reason is that Peter's automatic conversion toon failed and copied text, not numbers, into the |M| tag at the end of the next step. So when you accepted the Do Unto Others quest, it tried to map something that wasn't coords, and had a hernia.
I'll add some sort of quieter failure message that informs the user through chat that the coordinates were not entered correctly. Thanks very much for pointing this out.
If you want to try to fix the guide file yourself, just delete any |M| tag that does not include proper coordinates. Otherwise it will have to wait til I make a fix, which won't be tonight (sleep time now).
Thanks again for the detailed report :)
Hi again.
It seems that on every login after the above error, I get another. I suppose they are related as I guess it happens when WoWPro tries to set the waypoint that fails.
Date: 2010-08-08 11:14:01
ID: 1
Error occured in: Global
Count: 2
Message: ..\AddOns\TomTom\TomTom.lua line 786:
attempt to perform arithmetic on local 'x' (a string value)
Debug:
(tail call): ?
TomTom\TomTom.lua:786: AddZWaypoint()
WoWPro\WoWPro_Mapping.lua:38: MapPoint()
WoWPro\WoWPro_Broker.lua:49: LoadGuide()
WoWPro_Leveling\WoWPro_Leveling.lua:46:
WoWPro_Leveling\WoWPro_Leveling.lua:16
(tail call): ?
[C]: ?
[string "safecall Dispatcher[1]"]:9:
[string "safecall Dispatcher[1]"]:5
(tail call): ?
...\AddOns\AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:539:
...\AddOns\AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:532
(tail call): ?
WoWPro\WoWPro.lua:68:
WoWPro\WoWPro.lua:59
(tail call): ?
[C]: ?
[string "safecall Dispatcher[1]"]:9:
[string "safecall Dispatcher[1]"]:5
(tail call): ?
...\AddOns\AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:539: EnableAddon()
...\AddOns\AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:629:
...\AddOns\AtlasLoot\Libs\AceAddon-3.0\AceAddon-3.0.lua:615
[C]: LoadAddOn()
..\FrameXML\UIParent.lua:235: UIParentLoadAddOn()
..\FrameXML\UIParent.lua:258: CombatLog_LoadUI()
..\FrameXML\UIParent.lua:482:
..\FrameXML\UIParent.lua:454
Been looking through WoWPro_Leveling\Horde\002_73_75_Jame_Dragonblight.lua, it seems that there's no coordinates related to the Do Unto Others quest. Could this be the reason?
So, have made minor changes to WoWPro_Leveling\Horde\002_73_75_Jame_Dragonblight.lua. Just added coordinates for "Do Unto Others", the location of High General Abbendis as well as corrected the syntax error causing the quest waypoint to bug out. Now, they may be overly precise but at least they'll point one in the proper direction. Coorodinates were taken from wow.allakhazam.com. The edited file can be found here: git://gist.github.com/513953.git | http://gist.github.com/513953
Keep up the good work.
Alright, I believe I've fixed this so it silently errors out if the coordinates are not input correctly. Will be in the next official release, uploading to working git now.
Driz - this should be fixed in the version that will be released this coming week. Sorry for the inconvenience :(
I found one of these issues in 002_71_73_Jame_borean_tundra.lua. do you want these to just be corrected and uploaded?