Z-Perl Unit Frames

Z-Perl Unit Frames

15M Downloads

AutoBar version check fails.

neotron opened this issue ยท 0 comments

commented
22x ZPerl/ZPerl_Init.lua:577: attempt to compare nil with string
[string "@ZPerl/ZPerl_Init.lua"]:577: in function `ZPerl_Init'
[string "@ZPerl/ZPerl_Globals.lua"]:506: in function <ZPerl/ZPerl_Globals.lua:505>
[string "@ZPerl/ZPerl_Globals.lua"]:620: in function <ZPerl/ZPerl_Globals.lua:591>

This is the issue:

local ver = GetAddOnMetadata and C_AddOns.GetAddOnMetadata(name, "Version")

GetAddOnMetadata is not defined, so ver is just set to nil - true for all these checks. Should be something like

local GetAddOnMetadata = GetAddOnMetaData or C_Addons.GetAddOnMetadata

and then using that would work. OR just use C_AddOns.GetAddOnMetadata directly since it's used earlier in the same method.

The second issue is that just comparing by string isn't valid, since the current version of AutoBar is "11.". The string comparision returns false since 1 is less than 2.

Given how old the "old" AutoBar is perhaps the entire check is no longer needed.