ScrapYard (SYD) by magico13

ScrapYard (SYD) by magico13

4.2k Downloads

[BUG ๐Ÿž] Scrapyard compatibility issue with RealChute

genehwung opened this issue ยท 4 comments

commented

Describe the bug
Had reported this in the forum, but just to put it here to track.
RealChute recovery is broken with Scrapyard? Using a fresh 1.12 KSP, and only put in RealChute, KCT, and scrapyard (with their dependencies).

Error in the log:
[LOG 19:35:25.481] ------------------- initializing editor mode... ------------------
[LOG 19:35:25.481] editor started
[LOG 19:35:25.486] GetSubclassesOfParentClass: Using cached results for AlarmTypeBase
[LOG 19:35:25.487] Loading Depletion Nodes
[LOG 19:35:25.487] DepNodeCount: 0
[LOG 19:35:25.487] Loading Biome Nodes
[LOG 19:35:25.487] BiomeNodeCount: 0
[LOG 19:35:25.487] Loading Planet Nodes
[LOG 19:35:25.487] PlanetNodeCount: 0
[LOG 19:35:25.490] [ScenarioDestructibles]: Loading... 0 objects registered
[LOG 19:35:25.490] [ScenarioUpgradeableFacilities]: Loading... 0 objects registered
[WRN 19:35:25.560] UIList: RemoveItem didn't find any item to remove.
[LOG 19:35:25.570] Untitled Space Craft loaded!
[LOG 19:35:25.579] 9/5/2021 7:35:25 PM,KerbalConstructionTime-KACWrapper,Attempting to Grab KAC Types...
[ERR 19:35:25.586] Module ProceduralChute threw during OnStart: System.NullReferenceException: Object reference not set to an instance of an object
at RealChute.ProceduralChute.OnStart (PartModule+StartState state) [0x005b0] in :0
at Part.ModulesOnStart () [0x00120] in :0

To Reproduce

  • Steps to reproduce the behavior:
  • Start a new game
  • Any part with a parachute (realchute)
  • Fly and Recover to VAB using KCT
  • Use KCT to edit the same ship just recovered

Expected behavior
The realchute parachute will be considered used and correctly reduces the KCT construction time.

Desktop (please complete the following information):

  • OS: Win10
  • Browser chrome

Additional context
Tested Realchute by itself, it seems to have no such exception. So it might be the interaction between these two mods is having issues.

Full logs are here

commented

testing

@genehwung fresh KSP 1.12.2 installation - with everything freshly installed from CKAN - latest versions of everything; exception is Hyperspace, which is a personal fresh recompile (.NET 4.7.2 KSP 1.12.2)

I see the ERR in the log, but everything works correctly AFAIK - recover to VAB refurbishes and relaunches (I don't have much experience with KCT) and normal recovery recovers for parts. both show the parachute as used, and properly count it and the number of uses. images below.

most of the issues I saw in the log came from Module Manager, and of course miniavc (which I personally normally delete all copies and the contents of zeroMiniAVC because I believe they lead to game instability and slow down game loads).

am talking with more knowledgeable KSP C# modders now.

GameData folder
inuse-1
normalRecovery
reuse
reuse-2
reuse-3

commented

image

commented

Thanks for the debugging, I concur that Scrapyard does recognize it, just KCT is having issues to put it back on.
This is one of those bugs that each individual mod works fine standalone, but failed when together (RealChute + KCT + Scrapyard).

commented

@genehwung most certainly welcome. May I suggest bringing this (including the documentation you provided and mine) to KCT / RealChute devs? and maybe @linuxgurugamer - who excels at swatting this kind of bug?
๐Ÿž ๐Ÿ›ธ