ScrapYard (SYD) by magico13

ScrapYard (SYD) by magico13

4.2k Downloads

2.2.1.0-prerelease has wrong formatted KerbalChangelog config

Gordon-Dry opened this issue ยท 3 comments

commented

The first entry that is wrong makes KerbalChangelog crash and stop working:

	VERSION
	{
		version = v1.1.0.107 (2018-03-18)
		change = Added new event: "OnSYInventoryAppliedToPart". Fired when pressing "apply" from main UI on an existing part.
		change = Bug fix where Ids were not being set correctly when copying InventoryParts, which affected any parts that were added to the inventory and then used in the same scene (editing vessels in KCT, for instance)
		change = Changed Vessel tracking to fully remove a vessel from the list when setting the tracking state to false to avoid the list filling up unnecessarily.
	}

The version string is formatted wrong, see https://github.com/HebaruSan/KerbalChangelog
// Version number, numbers only with no spaces!

This results in

Uploading Crash Report
ArgumentException: Invalid version: v1.1.0.107 (2018-03-18)
  at KerbalChangelog.ChangelogVersion..ctor (System.String version, System.String cfgDirName) [0x0003a] in <3df0e8f79e4f4c60b17db000dc0cdeca>:0 
  at KerbalChangelog.ChangelogVersion..ctor (System.String version, System.String cfgDirName, System.String vName) [0x00000] in <3df0e8f79e4f4c60b17db000dc0cdeca>:0 
  at KerbalChangelog.ChangelogVersion..ctor (System.String version, System.String cfgDirName, System.String vName, System.String vDate, System.String vKSP) [0x00000] in <3df0e8f79e4f4c60b17db000dc0cdeca>:0 
  at KerbalChangelog.ChangeSet..ctor (ConfigNode vn, System.String cfgDirName) [0x0006c] in <3df0e8f79e4f4c60b17db000dc0cdeca>:0 
  at KerbalChangelog.Changelog+<>c__DisplayClass1_0.<.ctor>b__0 (ConfigNode vn) [0x00000] in <3df0e8f79e4f4c60b17db000dc0cdeca>:0 
  at System.Linq.Enumerable+SelectArrayIterator`2[TSource,TResult].ToList () [0x00014] in <351e49e2a5bf4fd6beabb458ce2255f3>:0 
  at System.Linq.Enumerable.ToList[TSource] (System.Collections.Generic.IEnumerable`1[T] source) [0x0001f] in <351e49e2a5bf4fd6beabb458ce2255f3>:0 
  at KerbalChangelog.Changelog..ctor (ConfigNode cn, UrlDir+UrlConfig cfgDir) [0x0011f] in <3df0e8f79e4f4c60b17db000dc0cdeca>:0 
  at KerbalChangelog.ChangelogAddonMainMenu+<>c.<Start>b__0_0 (UrlDir+UrlConfig cfg) [0x00006] in <3df0e8f79e4f4c60b17db000dc0cdeca>:0 
  at System.Linq.Enumerable+SelectArrayIterator`2[TSource,TResult].ToList () [0x00014] in <351e49e2a5bf4fd6beabb458ce2255f3>:0 
  at System.Linq.Enumerable.ToList[TSource] (System.Collections.Generic.IEnumerable`1[T] source) [0x0001f] in <351e49e2a5bf4fd6beabb458ce2255f3>:0 
  at KerbalChangelog.ChangelogAddonMainMenu.Start () [0x0004a] in <3df0e8f79e4f4c60b17db000dc0cdeca>:0 
UnityEngine.DebugLogHandler:Internal_LogException(Exception, Object)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
UnityEngine.Logger:LogException(Exception, Object)
UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)
 
(Filename: <3df0e8f79e4f4c60b17db000dc0cdeca> Line: 0)



commented

Thank you @Gordon-Dry !

I've just started working on automated changelogs, issue with template/automation - will fix.

I plan on doing another pass on SYD-OHS shortly - it is on the short list.

commented

correction - I added in the old changelogs, and need to finish formatting them. Thank you.

commented

removing KCL support from all mods.