[Bug 🐞]: SCON+KERB bug
TheNamedOyster opened this issue · 18 comments
Brief description of your issue
Science labs and ISRUs modifiers are being overridden by Kerbalism. Labs loose the ability to manufacture and store SCON components. ISRUs seem to maintain SCON material storage but are unable to manufacture.
9-2-22 Logs.zip
Steps to reproduce
Have SCON and Kerbalism installed.
Expected behavior
Ability to store/manufacture SCON components.
Actual behavior
Unable to store/manufacture SCON components.
Environment
Mod Version: SimpleConstruction-4.0.99.30-prerelease
KSP Version: 1.12.3.3173
SCON downloaded through Curse Forge most other mods through CKAN.
KSP.log and ModuleManager.ConfigCache in zipped folder.How did you download and install this?
CurseForge (download and manual installation)
Thank you. Kindly read contributiing.md, code_of_conduct.md and styleguide.md. These are boilerplate.
Thank you @TheNamedOyster 🦪 !
Started to work on this, for starters will just be a kludge to get things working -
Please try this (saying this now, and won't repeat - not on live saves, back up saves) patch: only contains the files that have changed.
SimpleConstruction-4.0.99.31-patch01-CF.zip
Kindly tell me if the science lab (any part that had a science lab) now can make RocketParts, has some storage for metal and rocketparts?
Kindly tell me if the science lab (any part that had a science lab) now can make RocketParts, has some storage for metal and rocketparts?
9-3-22 Logs_1.zip
Tested the patch. Science Labs still do not have storage for SCON parts, and are unable to produce them.
@TheNamedOyster haven't forgotten - should have two more attempts in the next day or so.
there will probably be another release before this fix is released into the wild.
I think I understand what is going on @TheNamedOyster
the issue appears to be the SC patch is looking for all parts that have a MODULE[ModuleScienceLab], which Kerbalism deleted and replaces with MODULE[Laboratory] (and other stuff); i.e. the SC patch finds no parts fulfilling it's :NEEDS and does nothing.
three ways to handle fixing for Kerbalism:
- patch before KerbalismDefault
use :FIRST or :BEFORE - patch after
look for MODULE[Laboratory] - or look for either module
@TheNamedOyster would you kindly try this patch?
apologies for the last patch having so many extraneous items.
SimpleConstruction-4.0.99.32-patch02.zip
Thank you again!
@zer0Kerbal Tested the patch, still no luck. Science labs do not have storage for SCON resources and are unable to produce them. ISRUs still have storage but cannot make more SCON resources. 10-1-22 Logs.zip
@TheNamedOyster thank you. 😞
missed about the ISRU's (was a real 🙈 / 🕶️ 🐭 moment )- well solving one will allow for fast fix on the other.
working on it... have another patch in my head - and will post it asap.
@zer0Kerbal Tested the patch, still no luck. Science labs do not have storage for SCON resources and are unable to produce them. ISRUs still have storage but cannot make more SCON resources.
10-1-22 Logs.zip
@TheNamedOyster going to simplify and see if it works.
ScienceLabs.zip
@zer0Kerbal
Alright I have tested the new patch. Science Labs can now store and manufacture Metal and Rocket parts.
On another note is this intended behavior?
I would think that manufacturing a craft should use Rocket Parts, not ore. Also the craft builds instantly. Is this a bug or just because I'm in Sandbox mode. Sorry if this is a dumb question, I don't have tons of experience with this mod outside of the minor troubleshooting I've done. It may also be related to the issue SCON has with KSPCF, which is a dependency for Kerbalism.
Anyway, thanks for your help so far.
Good news!
@TheNamedOyster The craft under construction - does it have storage for ore?
will answer more later.
No, I don't believe that the craft under construction does have room for ore.
Okay - kicked that bugs arse...
I will be installing a fresh KSP 1.12.3 SCON+KERB install and tackling this more directly @TheNamedOyster
@TheNamedOyster working on it right now.
@TheNamedOyster Ore bug is confirmed.
log pertaining to Large_Crewed_Lab
1518 [LOG 16:29:31.061] Load(Texture): Squad/Parts/Science/LargeCrewedLab/Large_Crewed_Lab
1519 [LOG 16:29:31.068] Load(Texture): Squad/Parts/Science/LargeCrewedLab/Large_Crewed_Lab_glow
2556 [LOG 16:29:38.701] Load(Model): Squad/Parts/Science/LargeCrewedLab/large_crewed_lab
2758 [LOG 16:29:39.630] Load(Model): Squad/Spaces/LargeCrewedLabInternals/Large_Crewed_lab_Int
3409 [LOG 16:29:48.258] Config(@PART[mk3Cockpit_Shuttle,Large_Crewed_Lab]:NEEDS[ProfileDefault]:FOR[KerbalismDefault]) KerbalismConfig/Profiles/Default/@PART[mk3Cockpit_Shuttle,Large_Crewed_Lab]:NEEDS[ProfileDefault]:FOR[KerbalismDefault]
4326 [LOG 16:29:48.294] Config(@PART[Large_Crewed_Lab]:NEEDS[FeatureHabitat]:AFTER[KerbalismDefault]) KerbalismConfig/System/Habitat/@PART[Large_Crewed_Lab]:NEEDS[FeatureHabitat]:AFTER[KerbalismDefault]
4518 [LOG 16:29:48.301] Config(@PART[Large_Crewed_Lab]:HAS[@MODULE[ModuleScienceLab]]:NEEDS[FeatureScience]:FIRST) KerbalismConfig/System/ScienceRework/Patches-Experiments/@PART[Large_Crewed_Lab]:HAS[@MODULE[ModuleScienceLab]]:NEEDS[FeatureScience]:FIRST
4793 [LOG 16:29:48.312] Config(@PART[Large_Crewed_Lab]:FINAL) SimpleConstruction/Config/SimpleConstruction/ScienceLabs/@PART[Large_Crewed_Lab]:FINAL
5616 [LOG 16:29:48.346] Config(PART) Squad/Parts/Science/LargeCrewedLab/largeCrewedLab/Large_Crewed_Lab
7271 [LOG 16:29:25.966] Applying update KerbalismConfig/System/ScienceRework/Patches-Experiments/@PART[Large_Crewed_Lab]:HAS[@MODULE[ModuleScienceLab]]:NEEDS[FeatureScience]:FIRST to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
7386 [LOG 16:29:26.487] Applying update KerbalismConfig/System/ScienceRework/Patches-Experiments/@PART[*]:HAS[@MODULE[ModuleScienceLab]]:NEEDS[FeatureScience] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
7491 [LOG 16:29:26.502] Applying update KerbalismConfig/System/ScienceRework/Patches-HardDrives/@PART[*]:HAS[@MODULE[ModuleScienceContainer]]:NEEDS[FeatureScience] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
7548 [LOG 16:29:26.626] Applying update KerbalismConfig/System/ScienceRework/Groups/LabExperiments/@PART[*]:HAS[@MODULE[Configure]:HAS[#title[Laboratory?Experiments]],!MODULE[Experiment]:HAS[#experiment_id[mobileMaterialsLab]]]:NEEDS[FeatureScience] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
7549 [LOG 16:29:26.650] Applying update KerbalismConfig/System/ScienceRework/Groups/LabExperiments/@PART[*]:HAS[@MODULE[Configure]:HAS[#title[Laboratory?Experiments]],!MODULE[Experiment]:HAS[#experiment_id[mysteryGoo]]]:NEEDS[FeatureScience] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
7550 [LOG 16:29:26.671] Applying update KerbalismConfig/System/ScienceRework/Groups/LabExperiments/@PART[*]:HAS[@MODULE[Configure]:HAS[#title[Laboratory?Experiments]]]:NEEDS[FeatureScience] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
7708 [LOG 16:29:26.832] Applying update KerbalismConfig/Profiles/Default/@PART[*]:HAS[#CrewCapacity[>0],!MODULE[KerbalSeat]]:NEEDS[ProfileDefault]:FOR[KerbalismDefault] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
7715 [LOG 16:29:26.842] Applying update KerbalismConfig/Profiles/Default/@PART[mk3Cockpit_Shuttle,Large_Crewed_Lab]:NEEDS[ProfileDefault]:FOR[KerbalismDefault] to Squad/Parts/Command/mk3CockpitShuttle/mk3CockpitShuttle.cfg/PART[mk3Cockpit_Shuttle]
7716 [LOG 16:29:26.843] Applying update KerbalismConfig/Profiles/Default/@PART[mk3Cockpit_Shuttle,Large_Crewed_Lab]:NEEDS[ProfileDefault]:FOR[KerbalismDefault] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
7820 [LOG 16:29:26.958] Applying update KerbalismConfig/System/Habitat/@PART[*]:HAS[!MODULE[Habitat],#CrewCapacity[>0],!MODULE[KerbalSeat]]:NEEDS[FeatureHabitat]:FOR[KerbalismDefault] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
7977 [LOG 16:29:27.113] Applying update KerbalismConfig/System/Reliability/@PART[*]:HAS[#CrewCapacity[>0],!MODULE[KerbalSeat]]:NEEDS[ProfileDefault,FeatureReliability]:FOR[KerbalismDefault] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
8312 [LOG 16:29:28.315] Applying update KerbalismConfig/System/ScienceRework/Patches-Experiments/@PART[*]:HAS[@MODULE[Experiment]]:NEEDS[FeatureScience]:FOR[KerbalismDefault] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
8364 [LOG 16:29:28.446] Applying update KerbalismConfig/System/ScienceRework/Patches-HardDrives/@PART[*]:HAS[@MODULE[Laboratory]]:NEEDS[FeatureScience]:FOR[KerbalismDefault] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
8388 [LOG 16:29:28.622] Applying update KerbalismConfig/System/ScienceRework/Groups/LabExperiments/@PART[*]:HAS[@MODULE[Configure]:HAS[#title[Laboratory?Experiments]]]:NEEDS[FeatureScience]:FOR[KerbalismDefault] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
8441 [LOG 16:29:28.942] Applying update KerbalismConfig/System/Habitat/@PART[Large_Crewed_Lab]:NEEDS[FeatureHabitat]:AFTER[KerbalismDefault] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
8550 [LOG 16:29:29.244] Applying update KerbalismConfig/System/Reliability/@PART[*]:HAS[@MODULE[Reliability],!MODULE[KerbalEVA]]:AFTER[KerbalismDefault] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
8696 [LOG 16:29:29.353] Applying update SimpleConstruction/Config/SimpleConstruction/CrewedPods/@PART[*]:HAS[#CrewCapacity[>0],!MODULE[ELWorkshop],!MODULE[ModuleScienceLab]]:NEEDS[Launchpad,SimpleConstruction]:FOR[SimpleConstruction] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
8846 [LOG 16:29:29.553] Applying update KerbalismConfig/Profiles/Default/@PART[*]:HAS[@MODULE[Configure]]:NEEDS[ProfileDefault]:FOR[zzzKerbalismDefault] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
8902 [LOG 16:29:29.762] Applying update KerbalismConfig/System/ScienceRework/Patches-Experiments/@PART[*]:HAS[@MODULE[Configure]:HAS[#title[Laboratory?Experiments]]]:NEEDS[FeatureScience]:FOR[zzzKerbalismDefault] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
9184 [LOG 16:29:30.999] Applying update KerbalismConfig/System/Reliability/@PART[*]:HAS[@MODULE[Reliability],!MODULE[KerbalEVA],!MODULE[ModuleEngines*]]:AFTER[zzzKerbalismDefault] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
9352 [LOG 16:29:31.058] Applying update SimpleConstruction/Config/SimpleConstruction/ScienceLabs/@PART[Large_Crewed_Lab]:FINAL to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]
10754 [LOG 16:30:08.533] PartLoader: Compiling Part 'Squad/Parts/Science/LargeCrewedLab/largeCrewedLab/Large_Crewed_Lab'
10755 [LOG 16:30:08.570] PartLoader: Part 'Squad/Parts/Science/LargeCrewedLab/largeCrewedLab/Large_Crewed_Lab' has no database record. Creating.
craft working with:
SCON+Kerb-01.zip
Game is Stock+DLC+SCON+KERB+MM+QuickStart with KERB+MM installed through CKAN, SCON+QS linked to local repos (custom build of QS without dependencies)
@TheNamedOyster Ore instead of RocketParts Issue found and working on solution
I had added a recipe to SCON to allow making shielding if KERB installed; and it used ore. So replaced Ore with RocketParts and issue resolved.
(bad joke (Avenue5) should have made the recipe use waste for the ingredient for shielding)