Ban Management

Ban Management

193k Downloads

Optional reason argument for /unban command

Agazed opened this issue ยท 11 comments

commented

Would be great for checking why a staff member unbanned someone.

Wrong name, appeal accepted, bought unban pass, mistake

Easy for keeping track why someone needed to be unbanned:

/unban <player> [reason]
commented

+1. Should be an optional argument though.

commented

I'd like to add this to the record tables, but if it's optional, it seems like a redundant column. Only normalisation alternative would be to create a new table but that seems a little extreme.

Would be nice to have on Frostcast too. I'll see if I can get this done today ๐Ÿ‘

commented

Wow! Didn't think this would get added let alone in a few hours.

Do I need to reset my database or anything? Anything I can configure?

Great work and thank you.

commented

The developer build will automatically add the columns. I've tested it, and it's working nicely. Just take note that the reasons are only stored in the database and are not yet within /bminfo.

They need to be added to the web interface cc @frdmn

I've left them out of the messages as they were odd without the reason due to joining words such as 'for'. Feel free to add [reason] to the unban notifications, the token will be replaced with the unban reason.

commented

Awesome. Do you have a CI server or do I have to compile myself?

commented

Nevermind, found your server.

commented

Uh yeah.
Just scrolled through the commit and it seems like changes in messages.yml are missing.

commented

As the reason is optional that would look weird when I add "for reason" and the reason is empty. In perfect condition there would be two messages. One handles with reason and one without.
As workaround I could put the reason ta the end and add something like "if provided"...
I'll see...

commented

Without giving reason you have () at the end which is an optical issue ๐Ÿ˜œ

commented

Mines set up like this

[player] has been unbanned by [actor] ([reason])
commented

Yes but I force my staff to type a reason.