IP address error preventing actions performed on players

Question

IP address error preventing actions performed on players

zombachu opened this issue 5 years ago · 22 comments

zombachu commented 5 years ago

Issue report

Tell us about your environment

Server Software: Paper
Server Version: Paper version git-Paper-145 (MC: 1.15.2) (Implementing API version 1.15.2-R0.1-SNAPSHOT)
BanManager Version: 7.1.0-SNAPSHOT built from dd442e6
Online/Offline mode: Online
Bungeecoord online/offline mode (if applicable):

BanManager config.yml:

# 
# Aliases will be found and blocked automatically, e.g. msg will block tell
debug: false
databases:
  local:
    enabled: true
    storageType: mysql
    host: 127.0.0.1
    port: 3306
    name: <>
    user: <>
    password: <>
    maxConnections: 10
    useSSL: false
    verifyServerCertificate: false
    leakDetection: 3000
    tables:
      players: bm_players
      playerBans: bm_player_bans
      playerBanRecords: bm_player_ban_records
      playerMutes: bm_player_mutes
      playerMuteRecords: bm_player_mute_records
      playerKicks: bm_player_kicks
      playerNotes: bm_player_notes
      playerHistory: bm_player_history
      playerReports: bm_player_reports
      playerReportLocations: bm_player_report_locations
      playerReportStates: bm_player_report_states
      playerReportCommands: bm_player_report_commands
      playerReportComments: bm_player_report_comments
      playerWarnings: bm_player_warnings
      ipBans: bm_ip_bans
      ipBanRecords: bm_ip_ban_records
      ipMutes: bm_ip_mutes
      ipMuteRecords: bm_ip_mute_records
      ipRangeBans: bm_ip_range_bans
      ipRangeBanRecords: bm_ip_range_ban_records
      rollbacks: bm_rollbacks
      nameBans: bm_name_bans
      nameBanRecords: bm_name_ban_records
  global:
    enabled: false
    storageType: mysql
    host: 127.0.0.1
    port: 3306
    name: external_bans
    user: root
    password: ''
    maxConnections: 10
    useSSL: false
    verifyServerCertificate: false
    leakDetection: 0
    tables:
      playerBans: bm_player_ban_all
      playerUnbans: bm_player_unban_all
      playerMutes: bm_player_mute_all
      playerUnmutes: bm_player_unmute_all
      playerNotes: bm_player_note_all
      ipBans: bm_ip_ban_all
      ipUnbans: bm_ip_unban_all
  convert:
    enabled: false
    host: 127.0.0.1
    port: 3306
    name: local_bans
    user: root
    password: ''
    maxConnections: 10
    tables:
      bansTable: bm_bans
      bansRecordTable: bm_ban_records
      ipBansTable: bm_ip_bans
      ipBansRecordTable: bm_ip_records
      kicksTable: bm_kicks
      mutesTable: bm_mutes
      mutesRecordTable: bm_mutes_records
      playerIpsTable: bm_player_ips
      warningsTable: bm_warnings
mutedCommandBlacklist:
- msg
- tell
- whisper
- r
- me
- mail
softMutedCommandBlacklist:
- msg
duplicateIpCheck: true
bypassDuplicateChecks:
- 0.0.0.0
- 127.0.0.1
logKicks: true
logIps: true
displayNotifications: true
broadcastOnSync: false
timeLimits:
  playerMutes:
    Moderator: 1d
  playerBans:
    Moderator: 7d
reportCooldown: 10
warningCooldown: 10
warningActions:
  enabled: false
warningMute: false
hooks:
  enabled: false
checkForUpdates: false
offlineAutoComplete: true
punishAlts: false
denyAlts: false
cleanUp:
  kicks: 0
  banRecords: 0
  ipBanRecords: 0
  ipMuteRecords: 0
  muteRecords: 0
  readWarnings: 0
  unreadWarnings: 0
  playerHistory: 0
maxOnlinePerIp: 0
maxMultiaccountsRecently: 0
multiaccountsTime: 300
checkOnJoin: false
createNoteReasons: false
onlineMode: true
chatPriority: normal
blockInvalidReasons: false

Describe your issue:

Not sure whether this is relevant but to provide context, after a server restart a week ago (in which we didn't change anything regarding the server software, configs, or anything in relation to banmanager, mysql, or the machine the server runs on), 6.0.2 randomly started failing on startup with the following error:

[23:54:12] [Server thread/WARN]: java.sql.SQLDataException: Cannot determine value type from string '��'
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:114)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:97)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:89)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:63)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:73)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:96)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.mysql.cj.jdbc.result.ResultSetImpl.getLong(ResultSetImpl.java:923)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.hikari.pool.HikariProxyResultSet.getLong(HikariProxyResultSet.java)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.ormlite.jdbc.JdbcDatabaseResults.getLong(JdbcDatabaseResults.java:160)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.ormlite.field.types.LongObjectType.resultToSqlArg(LongObjectType.java:37)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.ormlite.field.BaseFieldConverter.resultToJava(BaseFieldConverter.java:26)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.ormlite.field.FieldType.resultToJava(FieldType.java:841)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.ormlite.stmt.mapped.BaseMappedQuery.mapRow(BaseMappedQuery.java:61)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.ormlite.jdbc.JdbcDatabaseConnection.queryForOne(JdbcDatabaseConnection.java:315)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.ormlite.jdbc.JdbcDatabaseConnection.queryForOne(JdbcDatabaseConnection.java:229)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.ormlite.stmt.mapped.MappedQueryForFieldEq.execute(MappedQueryForFieldEq.java:38)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.ormlite.stmt.StatementExecutor.queryForId(StatementExecutor.java:94)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.ormlite.dao.BaseDaoImpl.queryForId(BaseDaoImpl.java:229)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.storage.PlayerStorage.setupConsole(PlayerStorage.java:62)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.storage.PlayerStorage.<init>(PlayerStorage.java:45)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.BanManager.setupStorages(BanManager.java:356)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.BanManager.onEnable(BanManager.java:138)
[23:54:12] [Server thread/WARN]: 	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263)
[23:54:12] [Server thread/WARN]: 	at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:337)
[23:54:12] [Server thread/WARN]: 	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:483)
[23:54:12] [Server thread/WARN]: 	at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugin(CraftServer.java:470)
[23:54:12] [Server thread/WARN]: 	at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugins(CraftServer.java:384)
[23:54:12] [Server thread/WARN]: 	at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:482)
[23:54:12] [Server thread/WARN]: 	at net.minecraft.server.v1_15_R1.DedicatedServer.init(DedicatedServer.java:298)
[23:54:12] [Server thread/WARN]: 	at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:885)
[23:54:12] [Server thread/WARN]: 	at java.lang.Thread.run(Thread.java:748)
[23:54:12] [Server thread/WARN]: Caused by: me.confuser.banmanager.internal.mysql.cj.exceptions.DataConversionException: Cannot determine value type from string '��'
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.mysql.cj.result.StringConverter.createFromBytes(StringConverter.java:131)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.mysql.cj.protocol.a.MysqlBinaryValueDecoder.decodeByteArray(MysqlBinaryValueDecoder.java:226)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.mysql.cj.protocol.result.AbstractResultsetRow.decodeAndCreateReturnValue(AbstractResultsetRow.java:143)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.mysql.cj.protocol.result.AbstractResultsetRow.getValueFromBytes(AbstractResultsetRow.java:250)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.mysql.cj.protocol.a.result.ByteArrayRow.getValue(ByteArrayRow.java:91)
[23:54:12] [Server thread/WARN]: 	at me.confuser.banmanager.internal.mysql.cj.jdbc.result.ResultSetImpl.getNonStringValueFromRow(ResultSetImpl.java:656)
[23:54:12] [Server thread/WARN]: 	... 25 more

This prompted us to update to 7.0.4. However, previously-banned players were then able to join with the following error:

[03:45:47] [Craft Scheduler Thread - 288/WARN]: Plugin BanManager v7.0.4 generated an exception while executing task 43484
me.confuser.banmanager.common.ipaddr.AddressValueException: 55, IP Address error: exceeds address size
	at me.confuser.banmanager.common.ipaddr.format.standard.AddressDivisionGrouping.toSegments(AddressDivisionGrouping.java:596) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.ipv4.IPv4AddressSection.<init>(IPv4AddressSection.java:225) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.ipv4.IPv4AddressSection.<init>(IPv4AddressSection.java:277) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.ipv4.IPv4AddressNetwork$IPv4AddressCreator.createSection(IPv4AddressNetwork.java:325) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.ipv4.IPv4AddressNetwork$IPv4AddressCreator.createSection(IPv4AddressNetwork.java:50) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.IPAddressNetwork$IPAddressCreator.createAddress(IPAddressNetwork.java:173) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.IPAddressNetwork$IPAddressGenerator.from(IPAddressNetwork.java:623) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.IPAddressNetwork$IPAddressGenerator.from(IPAddressNetwork.java:606) ~[?:?]
	at me.confuser.banmanager.common.storage.mysql.IpAddress.sqlArgToJava(IpAddress.java:39) ~[?:?]
	at me.confuser.banmanager.common.ormlite.field.BaseFieldConverter.resultToJava(BaseFieldConverter.java:30) ~[?:?]
	at me.confuser.banmanager.common.ormlite.field.FieldType.resultToJava(FieldType.java:841) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.mapped.BaseMappedQuery.mapRow(BaseMappedQuery.java:61) ~[?:?]
	at me.confuser.banmanager.common.ormlite.jdbc.JdbcDatabaseConnection.queryForOne(JdbcDatabaseConnection.java:315) ~[?:?]
	at me.confuser.banmanager.common.ormlite.jdbc.JdbcDatabaseConnection.queryForOne(JdbcDatabaseConnection.java:229) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.mapped.MappedQueryForFieldEq.execute(MappedQueryForFieldEq.java:38) ~[?:?]
	at me.confuser.banmanager.common.ormlite.field.FieldType.createForeignObject(FieldType.java:1047) ~[?:?]
	at me.confuser.banmanager.common.ormlite.field.FieldType.assignField(FieldType.java:556) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.mapped.BaseMappedQuery.mapRow(BaseMappedQuery.java:72) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.SelectIterator.getCurrent(SelectIterator.java:297) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.SelectIterator.nextThrow(SelectIterator.java:168) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.SelectIterator.next(SelectIterator.java:181) ~[?:?]
	at me.confuser.banmanager.common.storage.PlayerBanStorage.getDuplicates(PlayerBanStorage.java:274) ~[?:?]
	at me.confuser.banmanager.common.listeners.CommonJoinListener.lambda$onPlayerLogin$1(CommonJoinListener.java:360) ~[?:?]
	at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftTask.run(CraftTask.java:84) ~[patched_1.15.2.jar:git-Paper-145]
	at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:54) ~[patched_1.15.2.jar:git-Paper-145]
	at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[patched_1.15.2.jar:git-Paper-145]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_212]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_212]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212]

I noticed that some commits were since made that resolved some issues regarding IP addresses and compatibility from previous versions, so we then updated to the latest commit at the time (80% sure it was dd442e6). For a while, everything seemed to be working fine. However, we discovered today that actions were unable to be performed on some players. The following examples are related to one player that was tempbanned (by name, not ip) before 6.0.2, though it should be noted that most other players that meet those same conditions do not result in this behavior.

Running /bminfo, /unban, /tempban, etc. results in errors similar to the following:

[11:36:08] [Craft Scheduler Thread - 1455/WARN]: Plugin BanManager v7.1.0-SNAPSHOT generated an exception while executing task 47775
me.confuser.banmanager.common.ipaddr.AddressValueException: 54, IP Address error: exceeds address size
	at me.confuser.banmanager.common.ipaddr.format.standard.AddressDivisionGrouping.toSegments(AddressDivisionGrouping.java:596) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.ipv4.IPv4AddressSection.<init>(IPv4AddressSection.java:225) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.ipv4.IPv4AddressSection.<init>(IPv4AddressSection.java:277) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.ipv4.IPv4AddressNetwork$IPv4AddressCreator.createSection(IPv4AddressNetwork.java:325) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.ipv4.IPv4AddressNetwork$IPv4AddressCreator.createSection(IPv4AddressNetwork.java:50) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.IPAddressNetwork$IPAddressCreator.createAddress(IPAddressNetwork.java:173) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.IPAddressNetwork$IPAddressGenerator.from(IPAddressNetwork.java:623) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.IPAddressNetwork$IPAddressGenerator.from(IPAddressNetwork.java:606) ~[?:?]
	at me.confuser.banmanager.common.storage.mysql.IpAddress.sqlArgToJava(IpAddress.java:39) ~[?:?]
	at me.confuser.banmanager.common.ormlite.field.BaseFieldConverter.resultToJava(BaseFieldConverter.java:30) ~[?:?]
	at me.confuser.banmanager.common.ormlite.field.FieldType.resultToJava(FieldType.java:841) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.mapped.BaseMappedQuery.mapRow(BaseMappedQuery.java:61) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.SelectIterator.getCurrent(SelectIterator.java:297) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.SelectIterator.nextThrow(SelectIterator.java:168) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.StatementExecutor.query(StatementExecutor.java:202) ~[?:?]
	at me.confuser.banmanager.common.ormlite.dao.BaseDaoImpl.query(BaseDaoImpl.java:278) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.QueryBuilder.query(QueryBuilder.java:366) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.Where.query(Where.java:480) ~[?:?]
	at me.confuser.banmanager.common.ormlite.dao.BaseDaoImpl.queryForEq(BaseDaoImpl.java:254) ~[?:?]
	at me.confuser.banmanager.common.storage.PlayerStorage.retrieve(PlayerStorage.java:198) ~[?:?]
	at me.confuser.banmanager.common.commands.InfoCommand.playerInfo(InfoCommand.java:83) ~[?:?]
	at me.confuser.banmanager.common.commands.InfoCommand.lambda$onCommand$0(InfoCommand.java:65) ~[?:?]
	at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftTask.run(CraftTask.java:84) ~[patched_1.15.2.jar:git-Paper-145]
	at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:54) ~[patched_1.15.2.jar:git-Paper-145]
	at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[patched_1.15.2.jar:git-Paper-145]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_212]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_212]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212]

We also use the web interface and that still properly reports the punishment info of the player in question. This player has not attempted to join since these errors have started.

How to replicate:

Run /bminfo, /unban, /ban, etc. on a player known to be affected by this issue.

Further information:

Thank you for your work on BanManager! We have been using it for over 6 years and greatly appreciate the time and support given to it

zombachu · Answer 1 · 2020-04-10T08:40:42.000Z

No, we do have other servers on the same machine that also use BanManager but they each point to their own MySQL database and have their own credentials. Would this be something possible to fix with an SQL command or should I resort to restoring a backup?

confuser · Answer 2 · 2020-04-10T08:46:58.000Z

Do you have the logs from when you updated to v7? It would have outputted errors if the conversion failed.

As for the error you received whilst on v6.0.2, it appears to be an issue with the data for your Console player. Can you run the following query and paste the output here?

SELECT HEX(`id`), INET_NTOA(`ip`), INET6_NTOA(`ip`), `name` FROM bm_players WHERE id = UNHEX('Paste Console uuid from console.yml here without -')

zombachu · Answer 3 · 2020-04-10T08:57:26.000Z

Sorry, I missed these logs when making my original issue. These are from the first start after updating to 7.0.4:

[00:12:24] [Server thread/INFO]: Enabling BanManager v7.0.4*
[00:12:24] [Server thread/WARN]: Loaded class javax.persistence.Entity from VoxelSniper v5.172.0-SNAPSHOT which is not a depend, softdepend or loadbefore of this plugin.
[00:12:24] [Server thread/WARN]: SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
[00:12:24] [Server thread/WARN]: SLF4J: Defaulting to no-operation (NOP) logger implementation
[00:12:24] [Server thread/WARN]: SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 103, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 110, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 122, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 124, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 126, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 144, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 167, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 173, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 176, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 213, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 245, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 255, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 275, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 276, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 277, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 278, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 279, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 280, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 281, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 282, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 283, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 329, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 330, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 331, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 333, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 335, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 336, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 338, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 347, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 349, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 367, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 371, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 375, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 376, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 379, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 380, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 381, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 382, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 383, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 387, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 389, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 396, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 398, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 400, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 401, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 402, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 404, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 406, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 409, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 410, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 411, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 415, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 418, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 426, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 427, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 429, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 430, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 431, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 433, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 439, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 440, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 442, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 443, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 444, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 445, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 446, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 447, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 448, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 449, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 451, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid player for ban 454, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid player for ban 455, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 456, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 457, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 458, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 459, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 461, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 462, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 463, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 464, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 465, ignored
[00:12:24] [Server thread/WARN]: Missing or invalid actor for ban 466, ignored
[00:12:24] [Server thread/INFO]: Loaded 135 bans into memory
[00:12:24] [Server thread/INFO]: Loaded 2 mutes into memory
[00:12:24] [Server thread/INFO]: Loaded 1 ip bans into memory
[00:12:24] [Server thread/INFO]: Loaded 0 ip mutes into memory
[00:12:24] [Server thread/INFO]: Loaded 0 ip range bans into memory
[00:12:24] [Server thread/INFO]: Loaded 0 name bans into memory

And here's the output from the query:

confuser · Answer 4 · 2020-04-10T09:04:39.000Z

Okay, so there is an issue with the associated actor fields. Can you run the following please?

SELECT b.id, b.actor_id, HEX(a.id), a.name, INET_NTOA(a.ip), INET6_NTOA(a.ip) FROM bm_player_bans b JOIN bm_players a ON a.id = player_id WHERE b.id = 103

zombachu · Answer 5 · 2020-04-10T09:08:19.000Z

Sorry, I blacked out the ip to avoid any privacy violations but it appeared to be a well-formed ipv4 address:

confuser · Answer 6 · 2020-04-10T09:15:48.000Z

Are the bans that were ignored all the same actor_id?

zombachu · Answer 7 · 2020-04-10T09:21:26.000Z

No, it appears that multiple staff as actors were affected.

Edit: I should also mention that some bans did migrate properly that had the same actor_ids that were included in the affected bans

Also wanted to mention that running /bminfo IsThrill works properly, and now running /bminfo WalexCode (the player being referred to in the original issue) no longer gives an error but the ban we previously did on him does not appear. Since the issue was made, WalexCode did attempt to join, but was blocked by the precaution we took of banning him using vanilla's system.

confuser · Answer 8 · 2020-04-10T09:26:17.000Z

So the ban isn't showing because it's being ignored on start up as it's having issue loading the actor. Can you run the same query with a different ban id and see what the results are? This time add lastSeen column, so:

SELECT b.id, b.actor_id, HEX(a.id), a.name, INET_NTOA(a.ip), INET6_NTOA(a.ip), a.lastSeen FROM bm_player_bans b JOIN bm_players a ON a.id = player_id WHERE b.id = 110

confuser · Answer 9 · 2020-04-10T09:29:10.000Z

Assuming you are still running v7, based on the stack traces it's an issue with the ip addresses. INET6_NTOA columns should show the correct value where as INET_NTOA should not. If INET_NTOA does show the correct IP then the conversion failed for that particular player record.

zombachu · Answer 10 · 2020-04-10T09:39:07.000Z

Curiously, after doing more log diving, it appears that the first restart after 7.0.4 created the same output mentioned above, but the restart after that (also on 7.0.4) instead gave just this:

[06:46:40] [Server thread/INFO]: Enabling BanManager v7.0.4*
[06:46:40] [Server thread/WARN]: Loaded class javax.persistence.Entity from VoxelSniper v5.172.0-SNAPSHOT which is not a depend, softdepend or loadbefore of this plugin.
[06:46:40] [Server thread/WARN]: SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
[06:46:40] [Server thread/WARN]: SLF4J: Defaulting to no-operation (NOP) logger implementation
[06:46:40] [Server thread/WARN]: SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[06:46:40] [Server thread/WARN]: Missing or invalid player for ban 455, ignored
[06:46:40] [Server thread/INFO]: Loaded 216 bans into memory
[06:46:40] [Server thread/INFO]: Loaded 2 mutes into memory
[06:46:40] [Server thread/INFO]: Loaded 1 ip bans into memory
[06:46:40] [Server thread/INFO]: Loaded 0 ip mutes into memory
[06:46:40] [Server thread/INFO]: Loaded 0 ip range bans into memory
[06:46:40] [Server thread/INFO]: Loaded 0 name bans into memory

and it has remained this since, both under the next restart also done under 7.0.4 and then a couple restarts done under the 7.1.0 build

zombachu · Answer 11 · 2020-04-10T09:40:37.000Z

and it looks like 455 is WalexCode lol

confuser · Answer 12 · 2020-04-10T09:47:03.000Z

It might be caused by an overzealous ip validation. It's a valid IPv4 value correct?

zombachu · Answer 13 · 2020-04-10T09:49:00.000Z

Yup, and it matches what other plugins/logs say his IP was.

confuser · Answer 14 · 2020-04-10T10:05:17.000Z

Without knowing the ip value it's going to be impossible to expect a fix. Would it be possible to share it either via email or discord?

confuser · Answer 15 · 2020-04-10T10:25:49.000Z

Resolved on Discord, likely due to an issue with ip conversion when updating from v6 to v7

confuser · Answer 16 · 2020-04-10T08:13:12.000Z

Are you running multiple servers pointing to the same database? This seems like corruption of ip addresses caused by dual running of v6 and v7

confuser · Answer 17 · 2020-04-17T20:35:09.000Z

@Sir-Will You'll need to update the ip address manually. First find/confirm the invalid ip address with the following query

SELECT HEX(`id`), INET_NTOA(`ip`), INET6_NTOA(`ip`), `name` FROM bm_players WHERE name = 'putTheNameHere'

Sir-Will · Answer 18 · 2020-04-17T20:42:24.000Z

So changing the entries with NULL to 0.0.0.0 will fix it?

Sir-Will · Answer 19 · 2020-04-17T20:44:05.000Z

Nvm, 0.0.0.0 doesn't work. To what value can I set the IP to resolve the issue as I can't set it to NULL?

confuser · Answer 20 · 2020-04-17T20:45:39.000Z

@Sir-Will, no, the INET6_NTOA column should be displaying the correct value. If it's not, then you need to update the ip address.

UPDATE bm_players SET ip = INET6_ATON('127.0.0.1') WHERE name = 'thePlayerName'

Replace 127.0.0.1 with the right ip address, if you're unsure leave it as 127.0.0.1

Sir-Will · Answer 21 · 2020-04-17T20:52:14.000Z

Thanks. I got some entries where IP4 is NULL too but that doesn't seem to throw an error, so I'm not going to change them.

I used the following query to fix all entries.

UPDATE bm_players SET ip = INET6_ATON('127.0.0.1') WHERE INET6_NTOA(`ip`) IS NULL;

Sir-Will · Answer 22 · 2020-04-17T19:02:46.000Z

I'm having the same issue. How was it resolved?

[21:02:06] [Craft Scheduler Thread - 1596/WARN]: [BanManager] Plugin BanManager v7.0.4 generated an exception while executing task 79792
me.confuser.banmanager.common.ipaddr.AddressValueException: 57, IP Address error: exceeds address size
	at me.confuser.banmanager.common.ipaddr.format.standard.AddressDivisionGrouping.toSegments(AddressDivisionGrouping.java:596) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.ipv4.IPv4AddressSection.<init>(IPv4AddressSection.java:225) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.ipv4.IPv4AddressSection.<init>(IPv4AddressSection.java:277) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.ipv4.IPv4AddressNetwork$IPv4AddressCreator.createSection(IPv4AddressNetwork.java:325) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.ipv4.IPv4AddressNetwork$IPv4AddressCreator.createSection(IPv4AddressNetwork.java:50) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.IPAddressNetwork$IPAddressCreator.createAddress(IPAddressNetwork.java:173) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.IPAddressNetwork$IPAddressGenerator.from(IPAddressNetwork.java:623) ~[?:?]
	at me.confuser.banmanager.common.ipaddr.IPAddressNetwork$IPAddressGenerator.from(IPAddressNetwork.java:606) ~[?:?]
	at me.confuser.banmanager.common.storage.mysql.IpAddress.sqlArgToJava(IpAddress.java:39) ~[?:?]
	at me.confuser.banmanager.common.ormlite.field.BaseFieldConverter.resultToJava(BaseFieldConverter.java:30) ~[?:?]
	at me.confuser.banmanager.common.ormlite.field.FieldType.resultToJava(FieldType.java:841) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.mapped.BaseMappedQuery.mapRow(BaseMappedQuery.java:61) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.SelectIterator.getCurrent(SelectIterator.java:297) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.SelectIterator.nextThrow(SelectIterator.java:168) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.StatementExecutor.query(StatementExecutor.java:202) ~[?:?]
	at me.confuser.banmanager.common.ormlite.dao.BaseDaoImpl.query(BaseDaoImpl.java:278) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.QueryBuilder.query(QueryBuilder.java:366) ~[?:?]
	at me.confuser.banmanager.common.ormlite.stmt.Where.query(Where.java:480) ~[?:?]
	at me.confuser.banmanager.common.ormlite.dao.BaseDaoImpl.queryForEq(BaseDaoImpl.java:254) ~[?:?]
	at me.confuser.banmanager.common.storage.PlayerStorage.retrieve(PlayerStorage.java:156) ~[?:?]
	at me.confuser.banmanager.common.commands.CommonCommand.getPlayer(CommonCommand.java:82) ~[?:?]
	at me.confuser.banmanager.common.commands.TempBanCommand$1.run(TempBanCommand.java:101) ~[?:?]
	at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftTask.run(CraftTask.java:63) ~[patched_1.12.2.jar:git-Paper-1598]
	at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:52) ~[patched_1.12.2.jar:git-Paper-1598]
	at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[patched_1.12.2.jar:git-Paper-1598]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_212]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_212]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212]

Share to

Issue report