Ban Management

Ban Management

Bukkit Plugins
193k Downloads

Use of rewriteBatchedStatements disables useServerPrepStmts

A248 opened this issue ยท 2 comments

commented

BanManager sets both useServerPrepStmts and rewriteBatchedStatements to true for the database driver:

BanManager/common/src/main/java/me/confuser/banmanager/common/BanManagerPlugin.java

Lines 325 to 327 in e7111d1

ds.addDataSourceProperty("useServerPrepStmts", "true");
ds.addDataSourceProperty("useLocalSessionState", "true");
ds.addDataSourceProperty("rewriteBatchedStatements", "true");

However, as described in the driver documentation, rewriteBatchedStatements disables useServerPrepStmts: https://mariadb.com/kb/en/about-mariadb-connector-j/

Thus I'd suggest that you remove rewriteBatchedStatements in favor of useServerPrepStmts, since the two are mutually exclusive and I would guess that useServerPrepStmts is more valuable in terms of performance.

commented

@A248 PRs are welcome, and feel free to join the Discord channel https://discord.gg/59bsgZB

commented

FYI, I'm already in the Discord channel if you'd like to speak to me. I had a discussion with you previously about creating a common standard for punishment plugin data in the form of CSV file.