CommunityBridge

15.5k Downloads

Something is not quite right (Async)

th2000125 opened this issue · 46 comments

commented
Hey I'm getting a error on the new version,

[16:02:38 WARN]: Exception in thread "Craft Scheduler Thread - 6"
[16:02:38 WARN]: org.apache.commons.lang.UnhandledException: Plugin CommunityBridge v2.6.0.000 generated an exception while executing task 105
at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:56)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException
at org.communitybridge.main.WebApplication$1.run(WebApplication.java:229)
at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftTask.run(CraftTask.java:71)
at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:53)
... 3 more
​
There is also a start up error, but there are no previous errors to be seen.

[15:47:52] [Server thread/INFO]: [CommunityBridge] Enabling CommunityBridge v2.6.0.000
[15:47:52] [Server thread/INFO]: [CommunityBridge] Permissions System: GroupManager
[15:47:52] [Server thread/ERROR]: [CommunityBridge] Simple synchronization disabled due to prior errors.
​
^ it is obviously not disabled and changed my rank but it seems to be having a few issues
Thanks for your time and the new update! 
commented

I'm poking my head in to say that I'm having a similar issue that has made the current version unusable for me. My stacktrace is as follows:

[20:26:21 WARN]: Exception in thread "Craft Scheduler Thread - 793" 
[20:26:21 WARN]: org.apache.commons.lang.UnhandledException: Plugin CommunityBridge v2.6.0.000 generated an exception while executing task 87888
        at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:56)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:745)
Caused by: java.util.ConcurrentModificationException
        at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:859)
        at java.util.ArrayList$Itr.next(ArrayList.java:831)
        at org.communitybridge.main.WebApplication.synchronizeGroupsSecondaryGameToWeb(WebApplication.java:777)
        at org.communitybridge.main.WebApplication.synchronizeGroupsSecondary(WebApplication.java:709)
        at org.communitybridge.main.WebApplication.synchronizeGroups(WebApplication.java:343)
        at org.communitybridge.synchronization.PlayerSynchronizationDispatcher.playerStateBaseSynchronization(PlayerSynchronizationDispatcher.java:67)
        at org.communitybridge.synchronization.PlayerSynchronizationDispatcher.synchronizePlayer(PlayerSynchronizationDispatcher.java:41)
        at org.communitybridge.main.WebApplication$1.run(WebApplication.java:229)
        at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftTask.run(CraftTask.java:71)
        at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:53)
        ... 3 more

All of my server staff keep losing their ranks as a result, and on the XenForo forum, they are set to the "Unregistered / Unconfirmed" group. I'm going to downgrade for the time being.

I am currently using the latest version of Spigot as of February 10th, 2015 at 9:00pm EST or so. I do not use Carbon.

commented

Alright! Sorry for not doing much this weekend, I have been away.

I will do a thoroughly debugging today, and find out 100% where the error is.

@jflory7 Wich permission plugin are you using?

commented

@jflory7 are you able to upload your config for CB? If so, remember to remove the sensitive information.

commented

@TEKAA92
I am using zPermissions with a database for my permissions. My CB configuration can be found here.

(Pasting the whole thing even with YAML syntax was probably not a good idea.)

commented

@jflory7
To be more specific, its when the plugin tries to synchronize the secondary group aka: Chat-Mods to the website that you get the error.

commented

@TEKAA92
Hmmm, that's strange. I just wonder why it works on 2.5.2, but when I upgraded to 2.6.0, it started throwing this error.

As for the group-mapping, that's just how XenForo handles the user groups. All of the single digit user groups were groups that were created earlier in the history of my site's existence. The Chat-Moderators group was added more recently, and as a result, it has a higher ID number, since XenForo never completely removes a group from the database, I suppose (i.e. even though I deleted group 18, it will not recreate a new group as ID 18, but ID 19 instead).

As for the Chat-Mods group not being treated as a primary group, it is not supposed to be a primary group, but rather only a secondary group. Normally, I have it set up so a player might be a registered member or a paid rank, and then a Chat-Mod would have those permissions + a little bit extra. On my site specifically, it grants them access to a special forum. Adding it as a primary group isn't an option as it would require me to structure my in-game hierarchy in a way that would mean giving ALL of my Chat-Mods either too many or too little permissions, since they all have different ranks in addition to being Chat-Mods.

I think I answered your questions sufficiently, but if not, just let me know where more clarification, if any, is needed.

commented

@jflory7
Alright, that answered everything.

Regarding why the error shows up in 2.6.0, I have no idea, I did no changes to the synchronization section, since this was doing just fine. I do not get the error myself, but I will look further into the code to see if I can find a solution to this.

Thank you for your patience!

commented

I get exacly same error message.
Changes which I have made to config: https://gist.github.com/terokorp/bff80230fcd0f00ee4e8
(general section: default, database: ok, player-user-linking: ok, all others disabled)
When logging in, it tells "Registered account, linked to forums", so connection works, but something is still broken.

commented

@jflory7

It looks like your error is due to simple synchronization and that the group id's aren't matching between either website & config or game & config, and you get an ArrayList error.

I see that under group-mapping that you have an interesting setup. Is there a reason to why you have it set up as you have with one being '29' and the rest in single digits?

I noticed now that in the primary mapping, that you do not have listed Chat-mods as a primary group:
groups-treated-as-primary: ['default', 'Members', 'Trial-Mods', 'Moderators', 'Admins', 'Owners']

Why not? is this intentional?

commented

@jflory7
Ok, I did some debugging and have a test version ready for you to test and see if the errors still appears.

Dropbox link:
https://www.dropbox.com/s/6m783ks65p41rwo/CommunityBridge-test.jar?dl=0

commented

That version works on my server

commented

@terokorp
Good! thanks for the feedback

commented

@TEKAA92
It's showing me that the file was moved or deleted.

commented

I changed the name of it. Here's the new link

https://www.dropbox.com/s/pw8v5lwwof60td9/CommunityBridge.jar?dl=0

commented

@th2000125 @jflory7
Updated the plugin to fix the synchronization error.

I will close this issue if none of you are experiencing error on this anymore.

commented

@th2000125 Alright! Awesome :)

commented

Hi @TEKAA92 Thanks for your help!
Although all the errors have stopped! thank you so much!
I seem to have fixed the moving issue just now :P - that's why this is edited

commented

@TEKAA92
I just updated to 2.6.0B on my server, and it seems the issue is resolved. I tried typing /cbsync on a few players to test, and nothing unexpected happened.

I think it's safe to say it's fixed! If I encounter any issues, I will either reopen this issue or file a new one.

Thanks for the quick fix and friendly support!

commented

Im glad to hear that! :)

commented

I'm not at home atm, but is the first error at start up or does it appear later ?

commented

Can you add your log to this convo? I would like to see where the error might have occured, since I experience no such error myself. I see that you use Groupmanager, wich I do not. That might be a plausible cause.

@th2000125

commented

Is there a more private method I can use? as there is sensitive information inside that can't be publicly disclosed.
Thanks for the quick response!

commented

send me a pm, or you can just copy paste the start up log, and some of the log before the error and the error itself and some lines further. Leave out the sensitive stuff.

I just need to se how the plugin communicates with the rest of your plugins and if the error might be caused by another plugin.

commented

http://www.mediafire.com/download/4lryta8u8kz5ymg/latest.log
^ just removed all the IP's and so on
Thank you!

commented

The reason you get the CommunityBridge error is due to some error at the startup that makes CB disable Simple Synchronization.

I see that your server generates 2 errors before CommunityBridge.

NetherRoofProtect and Citizens.

Try to remove NetherRoofProtect and Citizens, and then do a start up and see if the error occurs.

commented

Okay am trying now

commented

Do the error occur now?

commented

Removed DTL traders, citizens, and roofprotect and I'm still getting the error

"[19:13:22 ERROR]: [CommunityBridge] Simple synchronization disabled due to prior errors."

"[19:16:40 INFO]: th2000125[/] logged in with entity id 121 at ([Vanilla] 5564.411708271654, 102.0, 6217.433420851549)
[19:16:40 INFO]: [Essentials] Lag Notice - Slow Permissions System (GroupManager) Response - Request took over 57.64ms!
[19:16:40 WARN]: Exception in thread "Craft Scheduler Thread - 1"
[19:16:40 WARN]: org.apache.commons.lang.UnhandledException: Plugin CommunityBridge v2.6.0.000 generated an exception while executing task 53
at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:56)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException
at org.communitybridge.main.WebApplication$1.run(WebApplication.java:229)
at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftTask.run(CraftTask.java:71)
at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:53)
... 3 more"

commented

Its detecting the Database but its moving (like before) me and others who are not member into member

commented

Hmmm... And when you used the 1.7 version. the same thing happens?

commented

I will test out a few things,
Try to use the 1.7 jar, cause it should work with the 1.8 client, and see if it generates the same errors.

commented

I will do

commented
commented

Try to set simple Synchronization to false and start the server

commented

No error on start up! :D

But this is still happening
[20:02:03 INFO]: th2000125[/] logged in with entity id 122 at ([Vanilla] 5566.142536289526, 87.76858102247299, 5963.33912220311)
[20:02:03 WARN]: Exception in thread "Craft Scheduler Thread - 0"
[20:02:03 WARN]: org.apache.commons.lang.UnhandledException: Plugin CommunityBridge v2.6.0.000 generated an exception while executing task 53
at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:56)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException
at org.communitybridge.main.WebApplication$1.run(WebApplication.java:229)
at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftTask.run(CraftTask.java:71)
at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:53)
... 3 more

commented

Why that nullpointer though. lol
Looking through the config to see why.

commented

I'm trying spigot latest build.

commented

[20:18:24 INFO]: [Essentials] Lag Notice - Slow Permissions System (GroupManager) Response - Request took over 68.407ms!
[20:18:24 WARN]: Exception in thread "Craft Scheduler Thread - 0"
[20:18:24 WARN]: org.apache.commons.lang.UnhandledException: Plugin CommunityBridge v2.6.0.000 generated an exception while executing task 53
at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:56)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException
at org.communitybridge.main.WebApplication$1.run(WebApplication.java:229)
at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftTask.run(CraftTask.java:71)
at org.bukkit.craftbukkit.v1_8_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:53)
... 3 more

commented

I tried it with the carbon plugin with 1.7 and its happening

commented

Whats the build you are using?

commented

It sounds to me that there is either a config error, or another plugin that disables CB's synchronization

commented

Well its accessing the database, even when it says somethings gone wrong because it can find registered players.

commented

Yes, it connects and all, but when the simple synchronization is disabled, it will generate the error above.

It says that a prior error is the cause of the disabling. And I can not see any other errors in the log that might cause this, hence a possible config or plugin that interferes

commented

I don't mind sending the config, and I will try removing plugins until its only got this left.

commented

Let me have a look on the config, and remember to leave out the password and such :)

commented

If it helps I tried 1.7 again and the errors don't seem to be appearing.
But my players only want 1.8 so this is a problem :/