Lines being cut off
zeronerve opened this issue · 14 comments
The text in my holo is being cut off at various lengths. See the attached image. I'm running Paper 1.13.2 with the latest version of HD. Is there a line length limit?
Here's the code that generates the holo. I've tried this without StringBuilder with no change. I'm not using StringBuilder for any useful purpose, other than to see if it magically fixed the problem.
I'm using a singlar/plural method sp() to return appropriate labels.
If I log the textLine String, it returns the proper length.
If I remove all the ChatColors, the problem still occurs.
...
while (leadersIterator.hasNext()) {
Leader l = (Leader) leadersIterator.next();
StringBuilder textLine = new StringBuilder();
textLine.append(ChatColor.YELLOW + "#" + i + " " + ChatColor.GOLD + l.getUsername() + " : ");
textLine.append("" + ChatColor.WHITE + l.getPoints() + " " + ChatColor.LIGHT_PURPLE + sp(l.getPoints(), "Point", "Points"));
textLine.append(" " + ChatColor.WHITE + l.getCaptures() + " " + ChatColor.LIGHT_PURPLE + sp(l.getCaptures(), "Cap", "Caps"));
textLine.append(" " + ChatColor.WHITE + l.getWins() + " " + ChatColor.LIGHT_PURPLE + sp(l.getWins(), "Win", "Wins"));
textLine.append(" " + ChatColor.WHITE + l.getKills() + " " + ChatColor.LIGHT_PURPLE + sp(l.getKills(), "Kill", "Kills"));
textLine.append(" " + ChatColor.WHITE + l.getDeaths() + " " + ChatColor.LIGHT_PURPLE + sp(l.getDeaths(), "Death", "Deaths"));
textLine.append(" " + ChatColor.WHITE + l.getRecoveries() + " " + ChatColor.LIGHT_PURPLE + sp(l.getRecoveries(), "Recovery", "Recoveries"));
textLine.append(" " + ChatColor.WHITE + l.getGamesPlayed() + " " + ChatColor.LIGHT_PURPLE + sp(l.getGamesPlayed(), "Game", "Games"));
TextLine line3 = leaderboardHolo.appendTextLine(textLine.toString());
if (i > 3) leadersIterator.remove();
i++;
}
Before setting the line, could you get the string and check the length? The current length limit is 300, counting colors too (each one is 2 characters).
Thanks for your reply! The lines are only cut off in 1.8.9. in 1.13
everything is fine. is there a workaround?
…On Sun, Oct 20, 2019, 11:52 AM filoghost ***@***.***> wrote:
Before setting the line, could you get the string and check the length?
The current length limit is 300, counting colors too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#228?email_source=notifications&email_token=AIKIJMHHR5M4M4VT5SGPOFTQPSEFHA5CNFSM4I2MYWVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBYON5Y#issuecomment-544270071>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIKIJMHTMHC42D66GXS4WETQPSEFHANCNFSM4I2MYWVA>
.
I did some testing on 1.8.9. There is a limit of 256 characters, including colors, client side, and that cannot be bypassed. However, I've counted the characters in the screenshot and the total is 64 including colors. Are you using the vanilla 1.8.9 client?
supporting 1.8.9 is important to me since we have a group of players with
PVP focus. any ideas?
…On Mon, Oct 21, 2019, 8:36 AM zeronerve ***@***.***> wrote:
I must add that the last screen i sent was after modifying some of the
fields being displayed (percent wins, etc.). Problem still exists in 1.8.9.
On Mon, Oct 21, 2019 at 8:35 AM zeronerve ***@***.***> wrote:
> It looks like this in 1.13 ...
>
> [image: image.png]
>
> On Mon, Oct 21, 2019 at 8:02 AM zeronerve ***@***.***>
> wrote:
>
>> using vanilla yes. I've also tried it with Badlion Client (1.8.9) and
>> with Vanilla 1.8.9 + Optifine. All show cutoff lines. If I use Vanilla
>> 1.13.2 it shows the entire line.
>>
>> This is the code I'm using to build the holo...
>>
>>
>> this.leaderboardHolo = HologramsAPI.createHologram(plugin, this.leaderboardLoc);
>> TextLine line1 = leaderboardHolo.appendTextLine("All-time Leaders");
>> TextLine line2 = leaderboardHolo.appendTextLine("------------------------");
>> int i = 1;
>> ListIterator leadersIterator = leaders.listIterator();
>>
>> while (leadersIterator.hasNext()) {
>> Leader l = (Leader) leadersIterator.next();
>>
>> String spPoints = sp(l.getPoints(), "Point", "Points");
>> String spCaps= sp(l.getCaptures(), "Cap", "Caps");
>> String spWins = sp(l.getWins(), "Win", "Wins");
>> String spKills = sp(l.getKills(), "Kill", "Kills");
>> String spDeaths = sp(l.getDeaths(), "Death", "Deaths");
>> String spRecoveries = sp(l.getDeaths(), "Recovery", "Recoveries");
>>
>> StringBuilder textLine = new StringBuilder();
>> textLine.append(ChatColor.YELLOW + "#" + i + " " + ChatColor.GOLD + l.getUsername() + " : ");
>> textLine.append("" + ChatColor.WHITE + l.getPoints() + " " + ChatColor.LIGHT_PURPLE + spPoints);
>> textLine.append(" " + ChatColor.WHITE + l.getCaptures() + " " + ChatColor.LIGHT_PURPLE + spCaps);
>> textLine.append(" " + ChatColor.WHITE + l.getWins() + " " + ChatColor.LIGHT_PURPLE + spWins);
>> textLine.append(" " + ChatColor.WHITE + l.getKills() + " " + ChatColor.LIGHT_PURPLE + spKills);
>> textLine.append(" " + ChatColor.WHITE + l.getDeaths() + " " + ChatColor.LIGHT_PURPLE + spDeaths);
>> textLine.append(" " + ChatColor.WHITE + l.getRecoveries() + " " + ChatColor.LIGHT_PURPLE + spRecoveries);
>>
>> plugin.log(textLine.toString());
>> TextLine line3 = leaderboardHolo.appendTextLine(textLine.toString());
>> if (i > 3) leadersIterator.remove();
>> i++;
>> }
>>
>>
>> On Mon, Oct 21, 2019, 7:31 AM filoghost ***@***.***>
>> wrote:
>>
>>> I did some testing on 1.8.9. There is a limit of 256 characters,
>>> including colors, client side, and that cannot be bypassed. However, I've
>>> counted the characters in the screenshot and the total is 64 including
>>> colors. Are you using the vanilla 1.8.9 client?
>>>
>>> —
>>> You are receiving this because you authored the thread.
>>> Reply to this email directly, view it on GitHub
>>> <#228?email_source=notifications&email_token=AIKIJMGKAMSMIGHK3AHBPVDQPWOIRA5CNFSM4I2MYWVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB2EZTY#issuecomment-544492751>,
>>> or unsubscribe
>>> <https://github.com/notifications/unsubscribe-auth/AIKIJMBD5O3P3ZZ7RFTJWKLQPWOIRANCNFSM4I2MYWVA>
>>> .
>>>
>>
The image you are talking about was not uploaded. About 1.8.9 vs 1.13.2, are you talking about the client versions only? What version is the server running?
using vanilla yes. I've also tried it with Badlion Client (1.8.9) and with
Vanilla 1.8.9 + Optifine. All show cutoff lines. If I use Vanilla 1.13.2 it
shows the entire line.
This is the code I'm using to build the holo...
this.leaderboardHolo = HologramsAPI.createHologram(plugin, this.leaderboardLoc);
TextLine line1 = leaderboardHolo.appendTextLine("All-time Leaders");
TextLine line2 = leaderboardHolo.appendTextLine("------------------------");
int i = 1;
ListIterator leadersIterator = leaders.listIterator();
while (leadersIterator.hasNext()) {
Leader l = (Leader) leadersIterator.next();
String spPoints = sp(l.getPoints(), "Point", "Points");
String spCaps= sp(l.getCaptures(), "Cap", "Caps");
String spWins = sp(l.getWins(), "Win", "Wins");
String spKills = sp(l.getKills(), "Kill", "Kills");
String spDeaths = sp(l.getDeaths(), "Death", "Deaths");
String spRecoveries = sp(l.getDeaths(), "Recovery", "Recoveries");
StringBuilder textLine = new StringBuilder();
textLine.append(ChatColor.YELLOW + "#" + i + " " + ChatColor.GOLD
+ l.getUsername() + " : ");
textLine.append("" + ChatColor.WHITE + l.getPoints() + " " +
ChatColor.LIGHT_PURPLE + spPoints);
textLine.append(" " + ChatColor.WHITE + l.getCaptures() + " " +
ChatColor.LIGHT_PURPLE + spCaps);
textLine.append(" " + ChatColor.WHITE + l.getWins() + " " +
ChatColor.LIGHT_PURPLE + spWins);
textLine.append(" " + ChatColor.WHITE + l.getKills() + " " +
ChatColor.LIGHT_PURPLE + spKills);
textLine.append(" " + ChatColor.WHITE + l.getDeaths() + " " +
ChatColor.LIGHT_PURPLE + spDeaths);
textLine.append(" " + ChatColor.WHITE + l.getRecoveries() + " " +
ChatColor.LIGHT_PURPLE + spRecoveries);
plugin.log(textLine.toString());
TextLine line3 = leaderboardHolo.appendTextLine(textLine.toString());
if (i > 3) leadersIterator.remove();
i++;
}
…On Mon, Oct 21, 2019, 7:31 AM filoghost ***@***.***> wrote:
I did some testing on 1.8.9. There is a limit of 256 characters, including
colors, client side, and that cannot be bypassed. However, I've counted the
characters in the screenshot and the total is 64 including colors. Are you
using the vanilla 1.8.9 client?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#228?email_source=notifications&email_token=AIKIJMGKAMSMIGHK3AHBPVDQPWOIRA5CNFSM4I2MYWVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB2EZTY#issuecomment-544492751>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIKIJMBD5O3P3ZZ7RFTJWKLQPWOIRANCNFSM4I2MYWVA>
.
It looks like this in 1.13 ...
[image: image.png]
…On Mon, Oct 21, 2019 at 8:02 AM zeronerve ***@***.***> wrote:
using vanilla yes. I've also tried it with Badlion Client (1.8.9) and with
Vanilla 1.8.9 + Optifine. All show cutoff lines. If I use Vanilla 1.13.2 it
shows the entire line.
This is the code I'm using to build the holo...
this.leaderboardHolo = HologramsAPI.createHologram(plugin, this.leaderboardLoc);
TextLine line1 = leaderboardHolo.appendTextLine("All-time Leaders");
TextLine line2 = leaderboardHolo.appendTextLine("------------------------");
int i = 1;
ListIterator leadersIterator = leaders.listIterator();
while (leadersIterator.hasNext()) {
Leader l = (Leader) leadersIterator.next();
String spPoints = sp(l.getPoints(), "Point", "Points");
String spCaps= sp(l.getCaptures(), "Cap", "Caps");
String spWins = sp(l.getWins(), "Win", "Wins");
String spKills = sp(l.getKills(), "Kill", "Kills");
String spDeaths = sp(l.getDeaths(), "Death", "Deaths");
String spRecoveries = sp(l.getDeaths(), "Recovery", "Recoveries");
StringBuilder textLine = new StringBuilder();
textLine.append(ChatColor.YELLOW + "#" + i + " " + ChatColor.GOLD + l.getUsername() + " : ");
textLine.append("" + ChatColor.WHITE + l.getPoints() + " " + ChatColor.LIGHT_PURPLE + spPoints);
textLine.append(" " + ChatColor.WHITE + l.getCaptures() + " " + ChatColor.LIGHT_PURPLE + spCaps);
textLine.append(" " + ChatColor.WHITE + l.getWins() + " " + ChatColor.LIGHT_PURPLE + spWins);
textLine.append(" " + ChatColor.WHITE + l.getKills() + " " + ChatColor.LIGHT_PURPLE + spKills);
textLine.append(" " + ChatColor.WHITE + l.getDeaths() + " " + ChatColor.LIGHT_PURPLE + spDeaths);
textLine.append(" " + ChatColor.WHITE + l.getRecoveries() + " " + ChatColor.LIGHT_PURPLE + spRecoveries);
plugin.log(textLine.toString());
TextLine line3 = leaderboardHolo.appendTextLine(textLine.toString());
if (i > 3) leadersIterator.remove();
i++;
}
On Mon, Oct 21, 2019, 7:31 AM filoghost ***@***.***> wrote:
> I did some testing on 1.8.9. There is a limit of 256 characters,
> including colors, client side, and that cannot be bypassed. However, I've
> counted the characters in the screenshot and the total is 64 including
> colors. Are you using the vanilla 1.8.9 client?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#228?email_source=notifications&email_token=AIKIJMGKAMSMIGHK3AHBPVDQPWOIRA5CNFSM4I2MYWVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB2EZTY#issuecomment-544492751>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AIKIJMBD5O3P3ZZ7RFTJWKLQPWOIRANCNFSM4I2MYWVA>
> .
>
I must add that the last screen i sent was after modifying some of the
fields being displayed (percent wins, etc.). Problem still exists in 1.8.9.
…On Mon, Oct 21, 2019 at 8:35 AM zeronerve ***@***.***> wrote:
It looks like this in 1.13 ...
[image: image.png]
On Mon, Oct 21, 2019 at 8:02 AM zeronerve ***@***.***> wrote:
> using vanilla yes. I've also tried it with Badlion Client (1.8.9) and
> with Vanilla 1.8.9 + Optifine. All show cutoff lines. If I use Vanilla
> 1.13.2 it shows the entire line.
>
> This is the code I'm using to build the holo...
>
>
> this.leaderboardHolo = HologramsAPI.createHologram(plugin, this.leaderboardLoc);
> TextLine line1 = leaderboardHolo.appendTextLine("All-time Leaders");
> TextLine line2 = leaderboardHolo.appendTextLine("------------------------");
> int i = 1;
> ListIterator leadersIterator = leaders.listIterator();
>
> while (leadersIterator.hasNext()) {
> Leader l = (Leader) leadersIterator.next();
>
> String spPoints = sp(l.getPoints(), "Point", "Points");
> String spCaps= sp(l.getCaptures(), "Cap", "Caps");
> String spWins = sp(l.getWins(), "Win", "Wins");
> String spKills = sp(l.getKills(), "Kill", "Kills");
> String spDeaths = sp(l.getDeaths(), "Death", "Deaths");
> String spRecoveries = sp(l.getDeaths(), "Recovery", "Recoveries");
>
> StringBuilder textLine = new StringBuilder();
> textLine.append(ChatColor.YELLOW + "#" + i + " " + ChatColor.GOLD + l.getUsername() + " : ");
> textLine.append("" + ChatColor.WHITE + l.getPoints() + " " + ChatColor.LIGHT_PURPLE + spPoints);
> textLine.append(" " + ChatColor.WHITE + l.getCaptures() + " " + ChatColor.LIGHT_PURPLE + spCaps);
> textLine.append(" " + ChatColor.WHITE + l.getWins() + " " + ChatColor.LIGHT_PURPLE + spWins);
> textLine.append(" " + ChatColor.WHITE + l.getKills() + " " + ChatColor.LIGHT_PURPLE + spKills);
> textLine.append(" " + ChatColor.WHITE + l.getDeaths() + " " + ChatColor.LIGHT_PURPLE + spDeaths);
> textLine.append(" " + ChatColor.WHITE + l.getRecoveries() + " " + ChatColor.LIGHT_PURPLE + spRecoveries);
>
> plugin.log(textLine.toString());
> TextLine line3 = leaderboardHolo.appendTextLine(textLine.toString());
> if (i > 3) leadersIterator.remove();
> i++;
> }
>
>
> On Mon, Oct 21, 2019, 7:31 AM filoghost ***@***.***> wrote:
>
>> I did some testing on 1.8.9. There is a limit of 256 characters,
>> including colors, client side, and that cannot be bypassed. However, I've
>> counted the characters in the screenshot and the total is 64 including
>> colors. Are you using the vanilla 1.8.9 client?
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <#228?email_source=notifications&email_token=AIKIJMGKAMSMIGHK3AHBPVDQPWOIRA5CNFSM4I2MYWVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB2EZTY#issuecomment-544492751>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AIKIJMBD5O3P3ZZ7RFTJWKLQPWOIRANCNFSM4I2MYWVA>
>> .
>>
>
The server is 1.13.2 using Paper. With protocolsupport.
…On Mon, Oct 21, 2019, 11:13 AM filoghost ***@***.***> wrote:
The image you are talking about was not uploaded. About 1.8.9 vs 1.13.2,
are you talking about the client versions only? What version is the server
running?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#228?email_source=notifications&email_token=AIKIJMD23MHEMOX7UVDBIRTQPXIKXA5CNFSM4I2MYWVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB24MLQ#issuecomment-544589358>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIKIJMD2NYNQZHCV7J3L3HDQPXIKXANCNFSM4I2MYWVA>
.
I found the issue in ProtocolSupport's code: https://github.com/ProtocolSupport/ProtocolSupport/blob/master/src/protocolsupport/protocol/typeremapper/entity/metadata/types/base/LivingEntityMetadataRemapper.java#L17
It incorrectly limits the nametag to 64 characters, like it was in 1.6. Please open an issue on their repository. I'm closing this one, as the bug is not caused by Holographic Displays.
Thank you!
…On Mon, Oct 21, 2019 at 2:29 PM filoghost ***@***.***> wrote:
Closed #228 <#228>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#228?email_source=notifications&email_token=AIKIJMFLUE453BWPMGVGLHDQPX7JLA5CNFSM4I2MYWVKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOULDTZXY#event-2730966239>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIKIJMHWEX5EPYEMYKCUAZ3QPX7JLANCNFSM4I2MYWVA>
.
Do you know what Class handles this in protocolsupport?
…On Mon, Oct 21, 2019 at 7:08 PM zeronerve ***@***.***> wrote:
Thank you!
On Mon, Oct 21, 2019 at 2:29 PM filoghost ***@***.***>
wrote:
> Closed #228 <#228>
> .
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#228?email_source=notifications&email_token=AIKIJMFLUE453BWPMGVGLHDQPX7JLA5CNFSM4I2MYWVKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOULDTZXY#event-2730966239>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AIKIJMHWEX5EPYEMYKCUAZ3QPX7JLANCNFSM4I2MYWVA>
> .
>