Holographic Displays

Holographic Displays

3M Downloads

Errors when used in combination with BKCommonLib

Opened this issue ยท 2 comments

commented

Hey, I'm getting errors on startup when using Holographic Displays and BKCommonLib together. Both of the plugins seem to work fine, but can you take a look at it please?
Thanks

https://pastebin.com/Dw6mdvTt

(PS: I've also contacted the BKCommonLib dev, but he said it's probably caused by this plugin)

commented

Reason for this error is your stack trace checking in your function. You blindly assume there to be a caller at index 2, but when Im invoking it there is no such stack trace element, and a NPE occurs. A bounds check would work. https://github.com/filoghost/HolographicDisplays/blob/master/HolographicDisplays/Plugin/com/gmail/filoghost/holographicdisplays/nms/v1_11_R1/EntityNMSArmorStand.java#L138

Perhaps for added safety, also check that things like getFilename() arent null (because they originate from generated or internal code where no filename exists. Im unsure if that ever is null)

commented

I've also added a check for null filenames, thanks for finding the source of the problem @bergerkiller