Confirmation

• I have read the FAQ.
• I have tested the latest development build of Holographic Displays and the bug is still present.
• I have updated Spigot to the latest release for my particular Minecraft version.
• I made sure the bug hasn't already been reported on the issue tracker.

Description

Latest development build broke the visibility manage on every version (only testet on 1.19 and 1.18.2). All Players see all Holograms.

How to reproduce

1. create a holo
2. let them spawn only for certain users?

Server version

git-Purpur-1668 (MC: 1.19)

Holographic Displays version

3.0.0-SNAPSHOT-b224

Installed plugins that allow players to join with multiple Minecraft versions

No response

Additional information

No response

Same issue here, when I apply hologram.visibilityManager.isVisibleByDefault = false it's still visible for everyone, I have translated holograms to 2 languages and both are visible and overlaying, so I need to turn off some language to deal with it.

Please provide the code that you are using to spawn them only for certain users.

the whole class: https://paste.twerion.net/bufivepuxu.typescript

the important part of the code: https://paste.twerion.net/akusikifoq.typescript

It works flaweless with b223 or older

any update on this? :(

Hi, having the same issue here. If you need more details than the previous message, I can provide a sample plugin.

I can also confirm this issue

Same issue

Seems to be caused by V2VisibilityManager, inside the constructor there's an unused variable visibilitySettings. I was able to fix it by setting this.v3VisibilitySettings = visibilitySettings;. Not sure if that's intentional or not (saw you were refactoring visiblity settings not long ago), can you confirm @filoghost ?

I was testing with the new VisibilitySettings (the v3 API) which was working. The old one (v2 API) was not working properly because of a simple mistake. 4431605

Seems to be caused by V2VisibilityManager, inside the constructor there's an unused variable visibilitySettings. I was able to fix it by setting this.v3VisibilitySettings = visibilitySettings;. Not sure if that's intentional or not (saw you were refactoring visiblity settings not long ago), can you confirm @filoghost ?

Nice timing, we discovered it at the same time. That was the problem indeed.

Its now fixed thanks, but now, newest dev build is causing much laggs.

https://spark.lucko.me/8r7m0jkGuv