MythicMobs API changes seem to break Magic?
mercurialmusic opened this issue ยท 13 comments
Hey Nathan! Not sure if this is a you or them thing, but it looks like the MythicMobs peeps have been redoing their API again as of MM build 4052 and Magic won't enable when it is installed, with the following error: https://gist.github.com/mercurialmusic/c43bb1ddfbc1e4edbc39175978d493a1
This happened to several plugins, which is annoying, and of course they decide to make these changes on the first builds that support 1.18.2, so all the more annoying. Updated API examples here if it's useful: https://github.com/xikage/MythicMobs-API-Examples
Thanks!
Will it be dropped soon? I cant update my server because mythicmobs and magic don't have compatible 1.18.2 versions.
Will it be dropped soon? I cant update my server because mythicmobs and magic don't have compatible 1.18.2 versions.
For now you can at least add the following to your config.yml to disable the hook, but it seems like this might have some unintended consequences with magic mobs being able to spawn through the worlds configs. I haven't figured that one out yet/not even sure if it's related.
# MythicMobs integration, allows using mythicmobs in magic commands and configs
mythicmobs:
enabled: false
Thank you, mercuriualmusic! That would be my recommendation, too.
I still haven't 100% decided to ditch support versus upgrading, I was kind of just raging out about it.
But in the meantime, turning off the integration should fix any issues with Magic, at the cost of Magic not being able to apply modifiers to mythic mobs, a feature which I think very little people are using, and is the only thing really lost if the integration goes away.
I don't expect turning this off would cause any issues with magic mob spawning or anything else, so do please let me know if you find any evidence of that.
Yeah, I don't blame you tbh. That plugin is a hot mess at times. I imagine we'd still be able to use the castp in the command skill, which is all we've ever done with them at least.
The latest dev build has updated MythicMobs integration, but I have not tested it.
The new API is also incomplete, so I had to use some reflection. It's ugly and may be broken.
If you get a chance to test it out, please let me know.
Probably the most likely issue would be killing a mythic mob and then undoing that kill (Rollback, Counterspell) and having it not be a Mythic mob anymore.
Brilliant, ill start testing it tonight. Adding some bosses and spells to the server anyway so my players should find any major issues fairly quickly.
I haven't seen any issues with the build, everything starts up as it should at least. I know it was a tangential mention and might need a separate issue, but the magic mobs still are not replacing vanilla mob spawns as they should in our other side. I'm able to spawn magic mobs manually, but nothing is happening automatically anymore. Were there some changes I needed to make in the worlds configs that I missed/should have made?
Thanks!
I used the last dev build and it seems is still incompatible with MM.
If I did not use any cross -MM-Magic spells ... is this having any negative impact ?
Later Edit: I read everything above ... seems it should be ok for me
mythicmobs:
enabled: false
@TheDarthFather what version of MythicMobs are you using? I just downloaded the latest free version and I'm not getting any errors. I don't have access to the MM dev builds.
@TheDarthFather what version of MythicMobs are you using? I just downloaded the latest free version and I'm not getting any errors. I don't have access to the MM dev builds.
I used the last dev build ...
I did not update yet .. been a while since I had time to look on the server :) ... it seems they change disquises as well :(
I will check again later in the week!
I think it's safe to close this. Haven't had any issues with the integrations at least.
I believe the mob spawning issue I mentioned is separate but still unable to pinpoint. I was able to come up with workarounds to that by a combination of redoing my worlds configs (was still using the legacy worlds:
stuffs) and using MythicMobs to handle most of the spawning/replacing with Magic mobs.