Magic

Magic

190k Downloads

Citizens issue

Blamo27 opened this issue ยท 8 comments

commented

Hello !

It seems that when we enable the "welcome wand" option so that new players receive their first wand, many NPCs with the trait Sentry also receive a wand, as if they were new players as well. Beside the fact that it makes the save.yml of citizen far heavier (because of the additionnal data of the wands), it's also an issue with the sentries who don't have any weapon equipped : instead of having their fist, they yield a wand, and when they fight they fight with the wand (but not by using spells, they just punch people with the wand).

Can you help us ?

Spigot Version : 1.8.8
Magic Version : 5.5.6-SNAPSHOT (CombatTagPlus fix)

Our CombatTagPlus is set to kill instantly players.

Thanks. :)

commented

That's extremely weird. Does a Sentry trigger a player join event??

commented

I think yes, because I tried to give wands with a command when a new player join our server. (FirstCommandJoin)

And there is another bug :

http://i.imgur.com/nRtVKgA.png

We are in 1.8, but we are allowing 1.9.2 - 1.9.4 players. (ViaVersion)
--> Invisibility cloak

commented

?

commented

I added a check for NPCs in #1667

http://jenkins.elmakers.com/job/MagicPlugin/1667/

They will no longer be considered players at all by the internal code. I'm hoping there aren't any weird side-effects.

For the invis cloak- in the 1.8 version of Magic it uses an item, which in 1.8 MC is invisible. In 1.9 MC the player can see it.

There's nothing I can do about that, in 1.9 Magic it's an actual item that is made invisible via the 1.9-specific RP.

commented

Thanks :)

commented

@NathanWolf But the version 6.2 is for MC 1.9, and I'm still on 1.8.8 :(

commented

Ah, of course :p

I'll back port it when I get the chance.