Magic

Magic

190k Downloads

Non-printable character in number format string

Acrozi opened this issue ยท 41 comments

commented

image

How can i fix it?

commented

Under what conditions do you see this? Have you edited or customized any message files? using a different language?

As far as I know there are no non-standard spaces or commas in any of the builtin files, and I have not seen anyone else report this.

commented

My server is in Russian, but I haven't changed anything in the plugin.

commented

image

commented

Facing the same problem in new server without any plugins.

commented

I use the 1.18.2 paper

commented

Are you using the Russian localizations (/mconfig language RU)?

Are you using a resource pack with a custom font that is missing a comma?

commented

No, i have default settings without changes.
Yes, i using a russian version on my another server but i tested in english version and i got i same problem.

commented

Are you using a resource pack? If so can you turn it off? That doesn't look like the standard MC font.

commented

image

Without resource pack.

commented

image

commented

Can you turn off "Force Unicode Font"?

It really should just be a comma, I have no idea why it would be missing from your font. I will double-check myself in-game when I can.

commented

image
Still same.

commented

Is there any way i can remove a comma? In any config or?

commented

Thank you

Can you turn off "Force Unicode Font"?

It really should just be a comma, I have no idea why it would be missing from your font. I will double-check myself in-game when I can.

commented

The format strings are not currently customizable but I will add that as a feature in the next dev build.

commented

Thank you

commented

What version of plugin and paper u have on your demo.elmakers.com?
Cuz there is no problem.

commented

1.19.2 (fairly current), latest plugin.

The format string comes from something hard-coded so I'm not sure how it could be different. Are you using Magic's RP when connecting to the demo server?

commented

Yes, exactly the same...

commented

Some encoding problem? Idk ..

commented

You said you tested with no plugins? I could see ProtocolLib or ViaVersion or something that messes at the protocol level affecting this, but otherwise I have no way to know. This is between your server and your client, I'm just putting a string with a comma in it.

I think your best bet is to remove the comma in the next dev build, unless you want to keep trying to figure this out.

commented

Oof I just spent some time implementing this but apparently I have already done it, in a different way XD

Try /mconfig messages numbers.integer #

Will this affect the display of other digits?

commented

Oof I just spent some time implementing this but apparently I have already done it, in a different way XD

Try /mconfig messages numbers.integer #

commented

Hahaha you crazy maaaan, thank you!

commented

You said you tested with no plugins? I could see ProtocolLib or ViaVersion or something that messes at the protocol level affecting this, but otherwise I have no way to know. This is between your server and your client, I'm just putting a string with a comma in it.

I think your best bet is to remove the comma in the next dev build, unless you want to keep trying to figure this out.

Thank you a lot, and yes it would be nice if you give some more ways to customize SP displaying in next dev build,

commented

Anything considered a currency, yes, but I expect it will be the same problem anywhere. There's no real reason why a comma should work in one place but not any other.

But in the next dev build you could make this change specifically for SP if it ends up causing you problems.

commented

Anything considered a currency, yes, but I expect it will be the same problem anywhere. There's no real reason why a comma should work in one place but not any other.

But in the next dev build you could make this change specifically for SP if it ends up causing you problems.

Thank you, i'll wait for the next dev build!

commented

That is building now:

https://jenkins.elmakers.com/job/MagicPlugin/4196/

But I suggest trying to command I pasted above if you haven't already. I expect you'll want to fix any number displays from the plugin, not just SP.

commented

That is building now:

https://jenkins.elmakers.com/job/MagicPlugin/4196/

But I suggest trying to command I pasted above if you haven't already. I expect you'll want to fix any number displays from the plugin, not just SP.

Wow, already?

Yes, i've tried and it worked!

commented

image
:C

commented

R.I.P.

Fix hopefully building now

https://jenkins.elmakers.com/job/MagicPlugin/4197/

commented

Haha, thank you!

commented

image
Yeeey!

commented

Okay! Now.. Where can i customize currency?

commented

image
Thank you, i've found it;=)

commented

image
LOL

Problem fixed when i loaded up my server on my Linux VDS and no issues...

commented

Btw, another question off topic.
Is there some placeholders for Magic Arena? Or some integration with holograms?

commented

No, there is not

commented

Hi again! Is there some way i can fix it? Thank you a lot!

commented

Fix what? MagicArenas will not be getting any new features.

commented

Nothing.. I thought about if there was some way i could show leaderboard from Magic Arenas in holograms..