Magic

Magic

190k Downloads

Persistent Particle Effects Causing Performance Issues After Using Fling Magic

Wind0220 opened this issue · 9 comments

commented

After using the "Fling" magic, particle effects continue to generate upon landing until a jump is performed, causing an accumulation of particle effects that leads to lag and performance issues.

default.mp4
commented

I have checked and there are no exceptions or errors in the console😟

commented

Oh, I see. That is strange, I will see if I can reproduce- the landing rings should only stay for a second or so.

Have you checked your server logs to see if there are any errors happening when players use that spell?

commented

What version of the plugin are you on? /magic will tell you
Have you customized this spell at all?
I just tried it out on the latest dev build (10.8.10-snapshot) and I don't see this happening.

These effects are controlled by the land portion of the config, which looks like this (/meditor spell fling)

        land:
        -  sound: block_stone_step
           sound_pitch: 0.7
        -  class: EffectRing
           particle: block_crack
           source_location: feet
           period: 4
           particle_count: 80
           radius: 4
           particle_offset_x: 0.9
           particle_offset_z: 0.9
           particle_offset_y: 0.1

The definition does look a little weird, I am going to add iterations: 4 to it, which should be the default ... that means it should repeat only 4 times, every 4 ticks (period: 4) so lasting 16 ticks is just under a second.

commented

I'm using the latest development build (10.8.10-snapshot) as well, and I haven't configured this spell before... However, I'm sorry that the bug still occurs. If there's a way to potentially resolve this issue by adding iterations: 4 as a solution, that would be fantastic!

commented

The latest dev build has this change, though I'm not really expecting it to help :(

https://jenkins.elmakers.com/job/MagicPlugin/4235/artifact/Magic/target/Magic-10.8.10-SNAPSHOT.jar

I also reduced the iterations from 4 to 3, but if yours are just sticking on forever then something else is wrong.

commented

It sounds like your server and/or players are having a lot of issues with particle performance.

Your players can turn off spell particles in the enchantment table menu if it’s a problem for them.

It is generally dependent on the players’ computers, particles are almost entirely clientside - but if you think it is a problem server-wide there is a command to turn them off globally. I don’t know it offhand, but something like /mhelp disable particles might have it.

commented

You can also edit individual spells to tweak particle counts down. This is a good bit more complicated, but meditor spell fling for instance will get you started with that. Just replace fling with singularity to edit that spell instead.

commented

I apologize if I didn't explain clearly. The issue is that after using the "fling" magic, the particle effects generated upon landing persist and do not disappear. These effects continue until the player performs a jump. This behavior is causing inconvenience as players are required to jump to remove the effects manually. Thank you for your understanding.

commented

That's great news! In the latest version of the magic plugin, the bug with the "fling" spell has been fixed on my server. It's truly effective! Thank you so much for addressing this issue.