Magic

Magic

190k Downloads

Issues with Magic RP on 1.20.1 on latest dev build

I0nTech opened this issue · 32 comments

commented

With less than 6 spells in the spell hotbar, it fails to show the spell icons and shows this:
image
This is the case on both this custom modified RP and the magic default RP. Both are correctly configured and display correctly with more than 6 spells in the hotbar.

image

A fix by the community has been rolled out for 1.20+ packs, it'd be great if this change was posted to the magic repo.
https://discord.com/channels/580099743875727363/912845695256514621/1149750830560456725

commented

Gosh this is a rabbit-hole.

I have a strong suspicion it was this change in the bungee-chat code:

SpigotMC/BungeeCord@2a716bb

Which got pulled into Spigot here: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/spigot/commits/3bce7935c844cdc6709ace44f2446455a87a8240#Bukkit-Patches/0010-BungeeCord-Chat-API.patch

Which would have made it into the Paper #126 update.

I can't easily prove this suspicion nor do I have idea how to fix or workaround whatever is broken.

commented

If we move away from thinking this is some kind of version-specific problem then it could be a config issue on your end, nothing to do with the RP. Are you sure this is a new issue?

The default action_bar config looks like this- is it possible you're just missing the font config?

        action_bar:
          message: '$hotbar`{font:"default",text:" $extra"}`'
          font: "magic"
          open_message: ""
          interval: 250
          delay: 1500
commented

On 1.20.1, if that makes any difference - issue is present on a vanilla client too.

commented

This is my GUI config,
https://editor.elmakers.com/1q3zifjv

Specifically, I'm using gui_actionbar, and it works fine when there are more than 6 spells in the hotbar - less than that causes the issue shown. Can try and delete that file and try again, but all three versions of that message: '$hotbar{font:"default",text:" $extra"}' component yielded the same results.

Edit, even on the default GUI config, same results. Going to wipe the magic folder and try again.
image

commented

Well- let me try updating Paper on my server. Could be something changed or got bugged in a later version, I'm pretty far behind.

commented

Ah- ha.. broken on latest Paper.
Well... that sucks a bit!

commented

Well- let me try updating Paper on my server. Could be something changed or got bugged in a later version, I'm pretty far behind.

Yeah, even on magic default, no plugins, vanilla client 1.20.1 paper the issue's still there. Paper was the most likely culprit...

commented

Guess I'll be binary searching through the Paper build history until I find what broke it :|

commented

Guess I'll be binary searching through the Paper build history until I find what broke it :|

Oof. Wish you luck with your bogosort.

commented

Thanks :(
I didn't see anything suspicious in the Paper revisions so I'm guessing it came from some upstream merge.

commented

Suspicion confirmed, this got broken in Paper #126 which was just an upstream update.

So now I guess I gotta look at all the Spigot commits between Paper #104 (~2023-08-05) and #126 (~2023-08-13)

commented

EDIT: No, it does not seem like the community solution entirely works, the above issue when less than 6 spells are in the spell hotbar is still present. Seems more like a plugin-side issue, as the fonts themselves seem to be working correctly.

commented
Screenshot 2023-09-11 at 2 03 38 PM

I'm not seeing this problem at all - is there anything else required to make it happen?

The community solution seems hacky at best- the hotbar can't just always use the magic font or it won't be able to show text.

commented

Not sure, what RP are you using? I'm on 1.20.1 paper with the latest magic dev build, with a modified magic RP - that might be the cause but I can't tell why.

commented

I am using the ModelEngine variant, though I think since ME integration is broken I can revert my server to use the default "all" RP. I will do that and test again, but I can't imagine it matters since they all share the same font files.

commented

Ah, let me test without modelengine installed. That might be the cause
Edit: Nope, it's not modelengine, same result.
Edit of edit: Would sending over my server RP to debug be helpful?

commented

image
Yeah, same result

commented

Updated my server to just use the basic "robes" RP and it seems fine, too.

I am not going to have time to debug a custom RP, sorry :(

Can you try it with the official RP?

commented

Sure, 1 second - I'll install default

commented

It does seem like I should release a 1.20 RP with the correct pack-format version (15) but I can't imagine that fixing this problem.

Are you letting the server give you the RP or just adding it yourself to your RP folder?

commented

https://editor.elmakers.com/zcwq1oxy
Having magic send it over, can try putting it directly in the server config,yml file

Also you might want to hold off on fixing that MEG integration, MEG 4 is apparently a major overhaul of the system to use display entities instead of armor stands, and will likely break the API entirely if not replace it with a new one.

commented

ME breaks their API constantly, I think they don't care anymore since getting in bed with MythicMobs. I'm not really interested in continuing to support integration with it. Which is unfortunate, it's an insanely cool plugin.

Can you try joining the mine.elmakers.com server and see if the RP works for you there?

commented

Which server are you on?

commented

mine.elmakers.com, it's just one server, many worlds- RP doesn't change between them.

commented

mine.elmakers.com, it's just one server, many worlds- RP doesn't change between them.

Can't tell as I don't have a wand on the survival server - can't find a wand on any of the servers either.

commented

Gave you a wand, weird that you did not spawn with the crafting ingredients though? Or a navigator?

commented

Believe I've joined the survival server before, crafted a spellbook instead of a wand..,

commented

Issue still seems to be present, even with the new RP:
image

Going to remove all plugins but magic and see if that makes any difference...

commented

Nope, issue is still present, using /getrp survival on the latest dev build you just posted, not sure if that's the updated RP or not.
image

commented

You can /getrp url to see- the latest dev build should have 1.20 in the filename.

The only thing that changed is the pack-format, though- and historically that makes zero difference unless you try to download the RP and use it manually. The MC client won't let you use an outdated pack, even if it would work just fine if given by a server 🤷

commented

You can /getrp url to see- the latest dev build should have 1.20 in the filename.

The only thing that changed is the pack-format, though- and historically that makes zero difference unless you try to download the RP and use it manually. The MC client won't let you use an outdated pack, even if it would work just fine if given by a server 🤷

Uhhh, using this RP now, from the /getrp url link - issue is still present.
image

If you can join my server to see if it's my server or client or whatnot, that'd be very appreciated - no idea what's happening with this...

commented

"Fixed" (worked around) in latest dev build and released as 10.8.10 (this seemed like a major enough issue for a release).

My suspicion about the problem was correct - the new bungee-chat API has a "fix" in it that prevents legacy text from using a font. It sets a "reset" flag on the chat component which has it ignore all prior directives, such as a font. But since there isn't a way to specify a font in the legacy chat format, I was kind of stuck.

I don't think I could argue against the fix even though it broke my specific use-case.

So instead I copied the previous version of the relevant legacy conversion code from the bungee-chat repo into Magic and I'm using it instead.