Particles stopped working in 1.12?
mibby opened this issue ยท 6 comments
Magic dev 2162
Paper dev 1122 (Spigot 1.12)
When I look up and right click to equip the hat item, no particles show up. Did they break in 1.12 or am I missing something?
Spells.yml
magichat:
icon: diamond_axe:138
icon_disabled: diamond_hoe:138
hidden: true
icon_url: http://textures.minecraft.net/texture/2abee4fe341011b9a0ae2fb83644f695521fd4e4c6198fe23112f1acbf38369
category: utility
worth: 100
actions:
# Aim up and cast, and the hat goes on your head
alternate_up:
- class: Delay
delay: 1
- class: Hat
effects:
cast:
- class: EffectSingle
location: target
effectlib:
class: SphereEffect
iterations: 4
particle: smoke_large
parameters:
target_self: true
use_item: true
reason: custom
Wand.yml
hat_book:
name: Book Hat
mode: cast
active_spell: magichat
icon: diamond_spade:1
indestructible: true
locked: true
keep: true
effect_color: '888888'
spells:
- magichat
Are you looking in 3rd person? There's a cloud of smoke.
I am. I can record something in a bit to show you.
bound: true is what makes items bound to a player.
Thanks, I'll try that. Wiki page still needs to be finished. :)
https://github.com/elBukkit/MagicPlugin/wiki/WandParameters
I also noticed that
locked: true
keep: true
do not specify on the item that it is limited to that person only. Did that break too?
Particles appear working to me. Are you looking in 3rd person? There's a cloud of smoke.
bound: true is what makes items bound to a player.
locked means it can't be modified, keep means it's kept on death.
Seems pretty odd that particles for just that one spell would be broken - others are working?
Feel free to update the wiki if you want to lend a hand! ;)
@NathanWolf Sorry for the delay. Here is a video clip showing that particles do not display when equipping a magic hat. At the end of the video, I show that particles function on the server and are enabled / visible on the client.
Edit: removed
Am I missing something obvious?
(Wand) Hat.yml
hat_tophat:
name: TopHat Hat
mode: cast
active_spell: magichat
icon: diamond_spade:7
indestructible: true
locked: true
keep: true
bound: true
effect_color: '888888'
spells:
- magichat
Spells.yml
magichat:
icon: diamond_axe:138
icon_disabled: diamond_hoe:138
hidden: true
icon_url: http://textures.minecraft.net/texture/2abee4fe341011b9a0ae2fb83644f695521fd4e4c6198fe23112f1acbf38369
category: utility
worth: 100
actions:
# Aim up and cast, and the hat goes on your head
alternate_up:
- class: Delay
delay: 1
- class: Hat
effects:
cast:
- class: EffectSingle
location: target
effectlib:
class: SphereEffect
iterations: 4
particle: smoke_large
parameters:
target_self: true
use_item: true
reason: custom
Doing some further investigation, it seems to break when load_default_spells: false is set. Does the magichat spell rely on another spell for particles to function?
Edit: I think I see the problem. The particle effects stop working when no range is specified on the spell and when the default spell settings are missing.
Re-adding this to the spell;
range: 4
allow_max_range: true
as well as the 'default' settings
default:
# Spells take 15 minutes to return to full SP earning potential
earns_cooldown: 900000
# Enable this to prevent spell casts outside the world border
world_border_restricted: false
effects:
target_selected:
- class: EffectSingle
location: origin
sound: magic.hit
sound_volume: 0.5
- class: EffectSingle
location: target
use_block_location: true
color_override: color
effectlib:
class: CubeEffect
iterations: 15
particle: redstone
color: "00FFAA"
edgeLength: 1.2
enableRotation: false
offset: 0.5,0.5,0.5
- class: EffectTrail
particle: spell_mob
fail:
- class: EffectSingle
location: origin
sound: block_note_basedrum
sound_volume: 0.8
sound_pitch: 1.2
insufficient_resources:
- class: EffectSingle
location: origin
sound: block_note_bass
sound_volume: 0.7
sound_pitch: 1.2
insufficient_permission:
- class: EffectSingle
location: origin
sound: block_note_bass
sound_volume: 0.9
sound_pitch: 1.5
cooldown:
- class: EffectSingle
location: origin
sound: block_note_basedrum
sound_volume: 0.6
sound_pitch: 0.8
cursed:
- class: EffectSingle
location: origin
entity_effect: hurt
backfire:
- class: EffectSingle
location: origin
entity_effect: hurt
blocked:
- class: EffectSingle
location: origin
entity_effect: hurt
upgrade:
- class: EffectSingle
location: origin
sound: entity_player_levelup
firework: ball_large
progress:
- class: EffectSingle
location: origin
sound: entity_player_levelup
firework: ball_large
break:
- class: EffectSingle
location: target
effect: step_sound
earn_sp:
- class: EffectSingle
location: origin
sound: entity_player_levelup
sound_volume: 0.6
sound_pitch: 0.75
- class: EffectSingle
location: origin
sound: entity_experience_orb_pickup
sound_volume: 0.4
sound_pitch: 1.5
earn_scaled_sp:
- class: EffectSingle
location: origin
sound: entity_experience_orb_pickup
sound_volume: 0.6
sound_pitch: 1.5
reflect:
- class: EffectSingle
location: target
particle: fireworks_spark
particle_count: 3
particle_offset_x: 0.1
particle_offset_y: 0.1
particle_offset_z: 0.1
sound: magic.shimmer_quiet
cast_self: cast
no_target: cast
no_action: cast
alternate: cast
alternate_up: cast
alternate_down: cast
alternate_sneak: cast
fizzle: fail
cancelled: fail
entity_required: fail
living_entity_required: fail
player_required: fail
location_required: fail
world_required: fail
invalid_world: fail
seems to have fixed the problem.
Feel free to update the wiki if you want to lend a hand!
Sure thing, as soon as I figure out what each setting actually does. :)