Magic

Magic

190k Downloads

Deprecated event being listened for.

mibby opened this issue ยท 4 comments

commented

Paper dev 1167 (Spigot 1.12)

[17:54:27] [Server thread/WARN]: [Magic] "Magic v6.9.15" has registered a listener for org.bukkit.event.player.PlayerPickupItemEvent on method "public void com.elmakers.mine.bukkit.magic.listener.PlayerController.onPlayerPickupItem(org.bukkit.event.player.PlayerPickupItemEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [NathanWolf].
[17:54:27] [Server thread/WARN]: [Magic] "Magic v6.9.15" has registered a listener for org.bukkit.event.player.PlayerPickupItemEvent on method "public void com.elmakers.mine.bukkit.magic.listener.PlayerController.onPlayerPrePickupItem(org.bukkit.event.player.PlayerPickupItemEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [NathanWolf].
commented

Don't know why Paper deprecated that event, but I need to use it soooooo...

commented

Ah, I see it's been replaced with EntityPickupItemEvent

Magic favors backwards compatibility, Paper is far too eager to complain about deprecation, and that console message is misleading. Nothing about this has performance ramifications.

I'm afraid you'll have to live with the log spam for now, otherwise I'd have to make Magic a 1.12 only plugin which isn't going to happen anytime soon.

commented

Spigot actually deprecated it I believe. But all good.
https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/d00c0574cdfff2e4e330c683565e7e59d09ee852#nms-patches/EntityInsentient.patch

Any ETA on jenkins server coming back online? :)

commented

Nope. Hard to justify buying a new server for a project I do for free.