Magic

Magic

190k Downloads

Exploit - Wands are not bound when given from console and it goes into a slot currently not equipped.

mibby opened this issue · 11 comments

commented

Magic v6.9.18

@NathanWolf Found a little issue with bound: true.

All of my wands are set to be bound to the player to avoid them from being duped in creative. I provide wands to players from a shop that runs the command /mgive <player> <wand> 1 from console. Usually the wand is bound to the player upon receiving but if they are currently holding something in their inventory, the wand goes into another slot and does not get the bound attachment - allowing people to give away, sell, or even dupe the item.

pumpkin:
    name: Pumpkin
    mode: cast
    active_spell: magichat
    icon: diamond_spade:2
    indestructible: true
    locked: true
    keep: true
    bound: true
    effect_color: '888888'
    spells:
        - magichat
commented

Wands are bound on activate by design. I could see about adding an option to make them bind when using /mgive.

commented

Ohh! Nathan is this a new build? I would love to use this new option!

commented

Yup- it’s in the latest dev build. Set “bind_on_give: true” in config.yml

But note this makes it really hard to give yourself a wand that you intend to give to someone else!

commented

Ooooh it's not a 'per wand' thing? Gotchaaaa!

commented

Do you think a 'per wand' feature would be useful? or too micro?

commented

This feature isn't useful to me at all, so you tell me :)

I was under the impression you don't really use /mgive to give wands to players- isn't that all handled via shops and core?

commented

Yeah that's true! We do give out things mainly via our cnpc shops and core now. But nah, I don't think it's necessary! Thanks!

commented

Added "bind_on_give" config option. Set to true to have wands bind to players when using /mgive, /wand or /wandp.

Crafting behavior is unchanged. Default behavior is unchanged, being able to get unbound wands is a feature, not a bug/exploit.

commented

@NathanWolf Thanks for the new config setting! :) I'll compile the source and give it a test. However any chances on opening up the jenkins server again in the future for dev builds? http://jenkins.elmakers.com/login?from=%2F

commented

Oops, yeah that was an oversight. I just enabled anonymous access, you should be able to get in now.

commented

Great, thanks! :)