No difference between levels of buff
Ferocimo opened this issue ยท 2 comments
Hello,
The wand buffs, specifically the physical one and the overal one (these are the only ones I've tested to be honest), are not propperly working. There is a difference between no Protection and Protection I buff, but there is none betwheen a Protection I and Protection V buff.
We're using default config on these.
Thank you for looking into this when you'll have some time to spare.
Have you made any changes to any of the damage_types config options?
I'll test it out when I can, it's been a while since I really paid much attention to it, but I'm not sure how it could've gotten broken in such a weirdly specific way.
So, after a few tests I understood where the issue was coming from. It is indeed related to the damage_types config options, but is in fact due the explanation of this system. As I understood it, each "add_protection" buff is supposed to give, by default, an additionnel 0.2 "points" to the said protection ; until it reaches a maximum of 1. When it's 1 or above, the full reduction configured in the damage_type is applied ("For instance, if you have fire damage set to max_reduction of 0.5, a player with a protection.fire of 1.0 (100%, maxed out) will take 50% damage from all fire sources. A player with protection.fire of 0.5 will take 25% damage.").
It is in fact not working like that. Each "add_protection" buff adds 0.2 to the ACTUAL damage reduction, this means that if you have set the max reduction to 0.2 in damage_type, and the buff adds 0.2 per level, then you have it already maxed out directly at level one, and every additional level will not do anything.
As a solution to that, I simply proportionnally adapted the buff added at each level for each damage type. For instance, for "overall protection", the buff adds "x + 0.04", which means that at full buff (level V), it will add 0.2 of reduction, which is the maximum I set in damage_type.
I don't know if this is very clear, if you want I might be able to clarify.