Magic

Magic

190k Downloads

Potion Effects Not Always Working

tsgrissom opened this issue ยท 12 comments

commented

The target_source property for the AreaOfEffectAction does not work. The caster isn't targeted at all.

commented

target_self is what you're looking for, I think.

commented

Actually, it looks like AreaOfEffects might not be working at all.

commented

I am dubious...

commented

I just tested with protegototalus in my configs which was working last time I checked. Here's the spell I'm testing with right now.

commented

The spell works fine when not attached to an AreaOfEffect by the way which is where my conclusion came from. I thought at first it was a problem with target_source (a property of AreaOfEffect) but I'm thinking it's something else.

commented

There would be so many spells in the default configs broken if AOE wasn't working, though.

commented

Or maybe it's the potion effect applied by the AOE that isn't working. Super weird because the message will display for me but the effects aren't applied. This could explain why protegototalus isn't working.

commented

Wondering if you had a chance to look into this any further.

commented

I played with this a bit and honestly it seems like it may be a vanilla Spigot or Minecraft issue :(

Potion effects sometimes (randomly, it seems, I can find no pattern) just don't work. I can see in the code the Bukkit method to apply the potion effect is getting called, but it just doesn't work.

I tested with the vanilla Poison spell as well, since that one is easy to test on mobs- sometimes it works, sometimes it doesn't. I'll see if I can dig any deeper when I find the time.

commented

That's really unfortunate. Seems like there's been a lot of structural changes in MC code lately. Keep me updated!

commented

Yeah :( I can't imagine what else is going on... I traced the code to the Bukkit call, saw it was getting called, but still no effects in-game.

I have no idea how long it's been like this, I haven't had a chance to look through Spigot commits. It's possibly just some new bug that will get fixed quickly?

commented

Did you ever figure this out... ? It's been like a year, whoops XD