Magic

Magic

190k Downloads

Support 1.18

alexchandel opened this issue ยท 5 comments

commented

1.18 stable will be released 11/30. Could you confirm whether MagicPlugin is ready for 1.18? Or could you please ready support for 1.18 now to ease the transition? Maybe release a build in advance to test? Thank you.

commented

It's not possible to implement support until Spigot releases. This is usually within a day or so of release, they have done builds based on stable in the past but I don't think they've done that for the past few versions.

It'll get done as soon as it can :)

commented

Thank you! Love this plugin, can't play without it. Biggest changes are the extension of y-axis down to -64 and new biomes, if that sounds like it touches any of your code.

commented

I'm hoping I've done all I can so far!

Negative y support was adding with 1.17 and tested with a datapack, so I'm hoping no speedbumps there but we'll see.

Biomes are generally auto-detected from the Bukkit enum so hopefully ok.

The main issue is that Magic uses NMS .. so there is a 0% chance any current build of Magic will work on 1.18.

It will certainly require a new version, but hopefully that is a copy+paste job for the most part. It should be something I can do right away, once Spigot has their mappings and updated API available.

commented

Seems to be functional on the latest Spigot 1.18. (Little laggy but that might be Spigot.) I just notice this warning in the logs during plugin loading:

[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: jungle_edge
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: jungle_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: bamboo_jungle_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: modified_jungle_edge
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: wooded_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: dark_forest_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: swamp_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: desert_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: desert_lakes
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: deep_warm_ocean
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: birch_forest_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: tall_birch_forest
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: mountain_edge
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: gravelly_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: modified_gravelly_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: stone_shore
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_tundra
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_taiga_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: wooded_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: taiga_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_spruce_taiga
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_spruce_taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_tree_taiga
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_tree_taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: jungle_edge
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: jungle_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: bamboo_jungle_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: modified_jungle_edge
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: wooded_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: dark_forest_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: swamp_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: desert_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: desert_lakes
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: deep_warm_ocean
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: birch_forest_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: tall_birch_forest
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: mountain_edge
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: gravelly_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: modified_gravelly_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: stone_shore
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_tundra
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_taiga_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: wooded_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: taiga_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_spruce_taiga
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_spruce_taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_tree_taiga
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_tree_taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: jungle_edge
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: jungle_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: bamboo_jungle_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: modified_jungle_edge
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: wooded_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: dark_forest_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: swamp_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: desert_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: desert_lakes
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: deep_warm_ocean
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: birch_forest_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: tall_birch_forest
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: mountain_edge
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: gravelly_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: modified_gravelly_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: stone_shore
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_tundra
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_taiga_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: wooded_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: taiga_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_spruce_taiga
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_spruce_taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_tree_taiga
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_tree_taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: jungle_edge
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: jungle_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: bamboo_jungle_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: modified_jungle_edge
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: wooded_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: dark_forest_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: swamp_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: desert_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: desert_lakes
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: deep_warm_ocean
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: birch_forest_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: tall_birch_forest
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: mountain_edge
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: gravelly_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: modified_gravelly_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: stone_shore
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_tundra
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_taiga_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: wooded_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: taiga_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_spruce_taiga
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_spruce_taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_tree_taiga
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_tree_taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: jungle_edge
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: jungle_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: bamboo_jungle_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: modified_jungle_edge
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: wooded_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: dark_forest_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: swamp_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: desert_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: desert_lakes
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: deep_warm_ocean
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: birch_forest_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: tall_birch_forest
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: mountain_edge
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: gravelly_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: modified_gravelly_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: stone_shore
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_tundra
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: snowy_taiga_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: wooded_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: taiga_mountains
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_spruce_taiga
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_spruce_taiga_hills
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_tree_taiga
[23:44:00] [Server thread/WARN]: [Magic]  Invalid biome in biome_actions config: giant_tree_taiga_hills

How can I reset my Magic config without losing player data? (This world was created on 1.17.1.)

commented

Resetting won't help those warnings, unfortunately. They are coming from the camo armor and dragon, which currently won't work right.

Spigot/Mojang changed all of the biome names, it seems, so I have to rework a few places that use them all.