Issues with Totems of Undying

Question

Issues with Totems of Undying

GameGold231 opened this issue 4 years ago · 3 comments

GameGold231 commented 4 years ago

My Friends and I have been using this plugin for a while now and we discovered an issue where Totems of Undying do not work, and instead the plugin thinks a death has occurred. I was thinking maybe this was because it calculates whether the damage will take the player past zero, and since the Totem does the same thing it calculates a death anyways? What would happen if a death was instead triggered by EntityDeathEvent and not EntityDamageEvent?

Thanks

GameGold231 · Answer 1 · 2021-05-23T23:14:59.000Z

it looks like a workaround could be that you can check if there is a totem of undying in the main or offhand, and if not then continue. Check getItemInMainHand() and getItemInOffHand()
https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/inventory/PlayerInventory.html

awlck · Answer 2 · 2021-05-23T20:15:22.000Z

Oh, I wasn’t even aware that was a thing. (Goes to show how little Minecraft I’ve been playing over the past few years.) I remember EntityDeathEvent causing me a bit of a headache with the respawn screen and teleportation, and the easiest workaround seemed to be the EntityDamageEvent thing. Thanks for the heads-up — looks like I’ll need to approach this differently. Am 23. Mai 2021, 21:57 +0200 schrieb GameGold231 ***@***.***>:

…

My Friends and I have been using this plugin for a while now and we discovered an issue where Totems of Undying do not work, and instead the plugin thinks a death has occurred. I was thinking maybe this was because it calculates whether the damage will take the player past zero, and since the Totem does the same thing it calculates a death anyways? What would happen if a death was instead triggered by EntityDeathEvent and not EntityDamageEvent? Thanks — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

awlck · Answer 3 · 2021-06-02T20:16:09.000Z

I've put out a new release that should circumnavigate this issue for now.

Share to