Stargate Rewritten

Stargate Rewritten

241 Downloads

ChestShop Incompatibility

Pheotis opened this issue ยท 7 comments

commented
Background

A gate has a name, a destination, a network, and flags.

Description

If a gate is named after a number;
If its destination is named after a number;
if the player has a numeric username;
and if the gate has flags.

Chest shop will think that you are making a shop.
This will result in the portal being created, and the sign being removed thereafter.
The portal will still exist in stargate's database, pending a restart.

Trace

Shown when creating an Always On Portal named 10

[11:30:09 INFO]: [Stargate] [Stargate::onSignChange] Initialized stargate: 10
[11:30:09 WARN]: [Stargate] [Stargate] Sign block is not a Sign object
[11:30:09 INFO]: [Stargate] [Stargate::Portal::drawSign] Block: AIR @ Location{world=CraftWorld{name=lclo},x=-262.0,y=3.0,z=316.0,pitch=0.0,yaw=0.0}

Fails and produces [Shop] Player not found!

When attempting to create a new always-on portal on the same spot, it fails, with no in-game error message.
Instead fails to console with:

[11:36:31 INFO]: [Stargate] [Stargate::createPortal] idParent belongs to existing gate

Repro steps

Place a sign anywhere in the world as follows:

1
2
3
a
commented

Possibly related to #14, but unknown; appears to be two issues at this time.

EDIT: #14 definitely part of this issue -- closed as duplicate.

commented

Possibly related to #13 ?

commented

The [Shop] Player not found! message appears to be a conflict with https://www.spigotmc.org/resources/chestshop.51856/

commented

Narrowed the issue down to a conflict with chestshop; edited main post with applicable information.

commented

Possible patch on our end:
Not allowing players with numeric usernames to make numeric gates.

@Thorinwasher ?

commented

Posted on CS' tracker as well; let's see which side of the incompatibility is easier to fix.

commented

Fixed on ChestShop's side with better regex.