When a sapling is planted, it will "pop off" after a certain period of time.

I've tested this on all trees and the same thing happens.

hmmmm can you find out if this is a client delay (maybe it pops off instantly for players watching you)?

if not, can you estimate if this time matches any of your settings, e.g. sapling replant delay, auto destroy delay, and if it is the same time?

This did definately not happen on my test server, and I didnt get reports except for yours.

Seeing your config would be beneficial ;)

Config: http://pastebin.com/QaUfADP2

Don't have anyone to test client delay, but i see it get placed, it stays there for maybe 5-10 seconds, then pops off.

Really the only thing I change that might "cause problems" is Bottom Block has to be Broken First: true -> false

could you try two things, individually?

1. hit the bottom block, does that work then?

2. change the config setting to true and see if it works then (for the bottom block of course)

Okay so I reset my config and tried again with the same build, and the sapling still pops off.

I tested this on my Production server and Local server (with this as the only plugin)

I hit the bottom, it'll plant the sapling, it ll stay there for maybe 5-10 seconds, then "pop off" as if it wasn't able to grow there.

Tested running Spigot #1192 and just to be sure, switched to Craftbukkit #2959

I revert to v5.8.4, sapling replant and tree felling works fine. (but 1.7 trees do not work on this of course)

waaaaait a second. your pastebin'ed config is not being used on the latest version, it doesn't contain the latest tree types oO are you sure you're running the latest build, like 5.8.22+ ?

That config actually is using the latest version, it just wont update the config with the new values for some reason.

Regardless, I deleted that config entirely and generated a new one with v5.8.22 and the issue still remains.

I am 100% Positive I am on v5.8.22

@slipcor

v5.8.31 still has this issue... HOWEVER...

Now that the sapling replant delay is being read correctly, if I set the number high enough (I set it to 10) the sapling will NOT pop off.

I guess this means that your block breaking method is eating the sapling or something?

@slipcor

Okay, so by lowering the delay for tree destruction, and raising the sapling replant time, I can fix the issue assuming the tree isn't too large.

For some reason, the plugin appears to be eating the bottom block at the very end of the tree chop instead of at the very beginning. This is very easy to "see" by using this config: http://pastebin.com/xMhPAGX3

If you go cut down a smaller tree with that config, if you hit a log that isn't the bottom, you'll see itll break all of the blocks and save teh bottom for last, and then break the bottom.

However, even with this "fixed" config, very large trees that take awhile to destroy will still happen longer then the 10 second sapling replant delay, which leads to the same issue.

What's happening with the default config is that the sapling replant happens before the tree is fully cut down, which leads to the tree destruction killing the bottom block when it finishes.

So basically to fix this you either need to make the plugin break the bottom block first or simply remove the "removal" of the bottom block and let the sapling replant override the block with a sapling. Or maybe even verify when you're removing the bottom block that it isn't a sapling.

Regardless, that's my research and I'm pretty sure that's all I'll be able to figure out more about this.

Hope it helps!

do you know java? I attempted to do my best to actually NOT remove the bottom blocks at ALL. After determining the full tree, I manually remove all bottom blocks from the list "to be removed" and then, the sapling replant happens when ever.
I seem to miss occasions, but as I understood the code I partially rewrote and partially took over, I get all the tree blocks, when that is done, I remove the bottom blocks so they should not be popped as saplings :(

I've got a draft fix that skips saplings on block removals. It was the CleanRunner one that was doing it for me.
See commit filbert66@cbf4615

please PR it, I have been searching for some time ^^

It is currently embedded in my other PR. Generate a new PR 13, but it's still based on my earlier PR.
#16

On Tue, Dec 31, 2013 at 2:35 AM, slipcor [email protected] wrote:

please PR it, I have been searching for some time ^^

Reply to this email directly or view it on GitHub:
#12 (comment)

Fixed :)