WorldGuard

WorldGuard

8M Downloads

InvincibilityListener lag

LadyCailinBot opened this issue ยท 10 comments

commented

WORLDGUARD-3430 - Reported by ferdl9999

Hello,

i have a problem with worldguard v6 beta 5: the plugin causes a lot of lag in combination with citizens + sentry when hitting an npc. Here is a spigot timing: http://fs1.directupload.net/images/150322/c9t4ucst.png

commented

Comment by wizjany

Can you try with a newer version from http://builds.enginehub.org
If you're still having issues, run /wg profile -p and wait 5 minutes, then paste the link here.

commented

Comment by ferdl9999

I tried the newest development build but nothing changed.

Here is a spigot timing, started at the same time with the worldguard profiler: http://timings.aikar.co/?url=10652261

Here is the link to the worldguard profiler paste: http://paste.enginehub.org/KDJsK.profile
Pastebin link to the content of profile.txt: http://pastebin.com/CxLqCsZZ

commented

Comment by wizjany

Thanks, that's actually very informative. I've linked this to another issue that's related. It seems that there's a blockage in PEX that's affecting us when we create user sessions and checking permissions for them. I am not quite sure why it throws exceptions sometimes and not others. Possibly related to citizens/sentry npcs or something.

Although, while the event is taking a while, it doesn't seem to be affecting overall server performance. Your tps is fine.

edit: i just looked at pex - this is a very weird issue, it looks like pex doesn't even use those methods anymore, so I'm not sure where this is coming from.

commented

Comment by ferdl9999

The server hangs at the moment where i damage an npc. After that the server is running fine.

commented

Comment by wizjany

Ah ok, that's not really shown well in a 5-minute profiling. I think we might be able to fix this by ignoring NPCs, it seems to be confused because NPCs are technically Players. Still not exactly sure what's going on with PEX though.

commented

Comment by ferdl9999

When will it be fixed?

commented

Comment by PseudoKnight

Can't you use isNPC() in the InvincibilityListener?

commented

Comment by wizjany

yea, but there's also potentially other perms checks that might be on an NPC. might need to put it directly in plugin.hasPermission

commented

Comment by ferdl9999

When will it be fixed? Is there also a way to change the messages (e.g. Hey! Sorry, but you can't PvP here.)?

commented

Comment by PseudoKnight

You say "fixed" like something in WorldGuard is causing this. They'll work around the issue caused by other software.