Support for blocking firework player damage in 1.11.x
LadyCailinBot opened this issue ยท 11 comments
WORLDGUARD-3786 - Reported by mibby
Since 1.11.1+, fireworks now seem to do damage to players. Is it at all possible to add a config option to disable player damage from fireworks?
Comment by wizjany
do they somehow bypass pvp or other-explosions? i'm unfamiliar with what fireworks do.
Comment by mibby
According to reports I'm getting from players, supposedly. I have pvp and other-explosions (for endercrystal block-damage since there isn't a config setting for blocking block-damage for that item specifically) disabled in my global region.
Fireworks never use to do damage, just launch and go. Now in 1.11.1/2, they seem to hurt the player.
Comment by wizjany
oh is it just the player using them? not nearby players?
i guess mojang was just trying to nerf the elytra launcher then
Comment by ItsAZZA
Setting other-explosion to false doesn't cancel the firework explosion damage event. Firework explosions destroys entities (such as itemframes and armorstands) within the the explosion radius. It also deals damage to players and living entities. I hope this can be fixed in the near future.
Comment by wizjany
@ItsAZZA I don't know what version you're on but I fixed this two days ago. As per http://forum.enginehub.org/threads/firework-damage.16888/ I'm setting this to fixed. Tell me if some behavior needs to be changed still.
Comment by mibby
Hey, the issue tracker is back! :D
@wizjany Would it be possible to split this off into a separate flag or global config setting? I'd like to disable firework damage but keep other explosions globally.
Comment by wizjany
eh, i am kind of trying not to add more and more flags for everything right now tbh.
i suppose it's possible if it's really needed though, since it was recent and haven't released anything with it yet.
Comment by mibby
While I can't force your hand, I would greatly appreciate either a config toggle or a flag for it specifically. :) Lots of plugins seem to use firework particle effects for things so taking damage from it is quite annoying. You may not want to disable all other-explosions just to prevent firework damage, at least in my case I only want to block fireworks.
Comment by mibby
Thanks wizjany. Any chances on having a separate endcrystal-damage flag too to just specifically block endercrystal block damage instead of all 'other-explosion's?