WorldGuard

WorldGuard

8M Downloads

Blacklist on-use/on-place/on-drop deny issues

LadyCailinBot opened this issue ยท 2 comments

commented

WORLDGUARD-3929 - Reported by mrcoffee1026

With items that can be thrown like this I have the following set for a particular world:

[experience_bottle,egg,ender_pearl,fireworks,snowball,splash_potion]
comment=item is banned here
on-break=deny
on-destroy-with=deny
on-place=deny
on-use=deny
on-interact=deny
on-drop=deny
on-acquire=deny
on-dispense=deny

It's still possible to spam an endless quantity of splash_potions even with this. The world is creative (which is why this is so annoying). If the user searches up like a splash water they can hold down or spam the "1" key until one glitches into their inventory. Similarly, if they continite to attempt and hold down the right click to throw / use the item, they'lll eventually begin launching an endless supply of potion bottles or exp bottles to cause other players particle lag. I'm not getting any indication in the log that the blacklist is having errors or anything... generally the activity described is blocked as expected (simply selecting the item in inventory will erase it), but the glitch ability to bypass... means people are still bypassing it.

WorldGuard 6.2.2-SNAPSHOT;1713-d2c52f7

commented

Comment by wizjany

that seems like a server issue. add ",tell" to one of those actions and test it...if you get a message that it's been denied, worldguard is cancelling the events. if the event is happening anyway, that's for the server (spigot) to fix.

commented

Comment by mrcoffee1026

It is possible I missed a restart before adding the "on-dispense" and/or that reloading qorldguard won't take on the new conditions. While the actual action of throwing a splash potion is "using" the item, it did not tell me the item was banned on use, but did begin blocking the action after the last restart and I've not seen a case of where spamming it allowed the use again. However, one can still hold down a number on their hotbar to get the item placed from creative mode into their hotbar, and this is clearly a lack in the WorldGuard plugin, not the server itself. A similar issue existed within the slimefun guide where users could either place or remove items from a guide... a user wrote a quick patch that simply e.setCancelled(true); if the title of the window was the guide. This effectively prevents a user's ability to hold down a number to result in a spam glitch within the guide as well as solving the problems it was meant to address. In any case, your blacklist can be easily bypassed by either spamming or holding down the hotbar number where you want the item to appear. This is a plugin issue, not a server one. Also, as best as I have been able to determine, holding down a right click to "use" a splash potion registers as "dispensing" instead of using. I believe the 'on-dispensing' action was meant to specifically address redstone dispensers and not a users inventory, but unless I misunderstood the documentation, it doesn't appear that works exactly as it should either.