Worldguard permissions bug.
LadyCailinBot opened this issue ยท 3 comments
WORLDGUARD-4129 - Reported by andrewkm
Bob is owner of region spawn.
There is also a region spawntest which is a subregion (spawntest's parent is spawn).
Bob however is not owner of this subregion.
How can I allow bob to add owners to spawntest?
It seems as though Bob can add members to the spawntest subregion.
However Bob cannot add owners to the spawntest subregion.
Bob has both:
worldguard.region.addmember.own.*
worldguard.region.addowner.own.*
The member addition looks as such via verbose:
(https://i.imgur.com/FV9p2rX.png)
The owner addition which fails looks as such via verbose:
(https://i.imgur.com/VAr4Ssn.png)
(https://i.imgur.com/KVtpp7M.png)
It doesn't seem like the owner addition to the subregion is properly checking for worldguard.region.addowner.own.spawntest
If you fix this, as it's a pretty crucial bug, can you please add it to the 1.13.2 branch (I remember you saying you will only push actual bugs to the 1.13.2 branch)
Comment by andrewkm
It looks like adding this permission to bob:
worldguard.region.addowner.unclaimed.spawntest
Allows him to add owners, however, this is incorrect behavior as Bob has worldguard.region.addowner.own.*
Why can bob add members to spawntest even though it's unclaimed, but cannot add owners to spawntest?
Once again bob has both:
worldguard.region.addmember.own.*
worldguard.region.addowner.own.*
PS: Doesn't seem like WG has a worldguard.region.addowner.unclaimed.own.* permission.
As such the system is flawed in the above regard.
Comment by wizjany
try latest build I guess. that area of the code is a bit of a mess and it's hard to test the group settings (max-region-counts-per-player stuff). The unclaimed check isn't wrong, it just didn't care if parent regions were claimed. It should now check to see if any region in the hierarchy is claimed already, to be in more like with the normal addowner.own permissions.