Dashes in table-prefix causes SQL errors
LadyCailinBot opened this issue ยท 4 comments
WORLDGUARD-4151 - Reported by donkie
WorldGuard v7.0.1-SNAPSHOT;556b638
WorldEdit v7.0.1;61bc012
Paper git#221
MariaDB 10.4.8-MariaDB-1:10.4.8+maria~bionic
The table prefix I tried was 'wg-', and without looking at the source code it seems like you're not using `` quotes to escape it so mariadb complains. I'm not sure if mysql would give the same error. Changing the table prefix to wg_ fixed it.
Comment by donkie
Then I suggest you make it clear in the documentation that this is the case.
Comment by wizjany
fyi sql isn't supported atm. i suggest you just switch to yaml. there is no good reason to use sql.
Comment by donkie
I believe there are many good reasons to use a proper database over text based storage methods. The SQL storage driver seems to work just fine apart from this bug from what I've seen so far.
There's also no indication in the documentation that the sql storage method is not supported. https://worldguard.enginehub.org/en/latest/regions/storage/
Comment by wizjany
there's a bunch of other bugs in sql too, so no it doesn't "work just fine apart from this bug".
and saying there's good reasons doesn't actually mean there are.
regardless, I have no intention of fixing this or any other sql bug. so you can live with it or you can take my suggestions