WorldGuard

WorldGuard

8M Downloads

Config option to disable events

WarnDa opened this issue ยท 5 comments

commented

The Problem

Worldguard is always at the top list of plugins in spark
image

A Solution

Add more events to config that can be disabled.
For example :

  • pistons
  • fluids
  • dispensers

(I got no world where player could place piston and try to push items in regions they can't build, same with fluids)
As I only got a world spawn, and a world for their island (and superior already protect for this)

Alternatives

No response

Anything Else?

No response

commented

I already have in config :

high-frequency-flags: false
protect-against-liquid-flow: false

commented

Spark of 1hr to show that worldguard consume the most :
https://spark.lucko.me/Jr1ueGjUfI
image

commented

Honestly if you're trying to perform micro-optimisations like that, write a plugin to remove WorldGuard's event handlers from the Bukkit events.

These amounts are tiny and don't justify adding in configuration options that will lead to confused users. The existing ones are for situations where a trade-off between protection accuracy and speed can result in substantial TPS improvements, not minor savings. Users already change these settings and get confused why things don't work like they want; adding more without strong justification just doesn't make sense.

commented

"micro-optimisation", it would make worldguard consume 0.2% instead of 1% (so 5x less), I'm sure a lot of owner would be happy of that.

And you could change config to set a section where player see all events that can be disabled and 1-2 lines that explain what it means, so it wouldn't be a random settings in the middle of the config.

commented

yea ngl really considering removing the existing configs entirely because it either leads to people using the flags and not understanding why they aren't working (high freq flags), or turning off things like use-player-move and wondering why session flags aren't working.

edit: also want to note that the config options just skip the region checks. we still have event handlers registered because reloading WG's config would need special-case handling to unregister/reregister handlers otherwise which i really don't want to deal with. if you really care about performance that much you should do as maddy said and remove the handlers entirely via the bukkit api.