WorldGuard

WorldGuard

8M Downloads

Fix region group flags so they work properly

LadyCailinBot opened this issue ยท 2 comments

commented

WORLDGUARD-2827 - Reported by snap64

I was making a plugin using the WG API and I wanted to make a flag that was effective for the members/owners. I found that if I set the group flag to MEMBERS, it applied to members, but not owners. So when adding owners I then had to add them as members as well. I also found NON_MEMBERS to include the owners if they weren't also members, which again, owners should not be included in.

I believe the best solution would be having more region group options than just the 3 current ones, but rather 7. There should be: OWNERS, NON_OWNERS, MEMBERS, MEMBERS_ONLY, NON_MEMBERS, NON_MEMBERS_ONLY, and ALL. OWNERS would obviously just include owners, and MEMBERS would include both members and owners. MEMBERS_ONLY would be people who are members and not include the owners, and NON_MEMBERS_ONLY would be everyone not in MEMBERS_ONLY, which makes sense. NON_MEMBERS would simply be everyone who isn't a member or owner, and of course ALL would be everyone. This way all possible combinations of the three groupings(owners, members, and outsiders) are covered, providing much more control over who it applies to.

You should also explain more clearly, in the documentation, how the flag would affect the specified group, and how it would affect anyone not in the group, when set to DENY or ALLOW, as I was confused about this for some of the flags, like whether it would just be the default value, or the opposite value(opposite value would make more sense). It would also be wise to explain the MEMBERS_ONLY and NON_MEMBERS_ONLY flags as some people might be unsure of these. Also, on a side note, I was having troubles figuring out how the build flag worked as it just says not to change it in the documentation, but I wanted to change who could construct there, rather than just having members and owners.

This would greatly improve the power and customization in the group flags, and possibly more people would be inclined to use it :)

Thanks for considering my suggestions

commented

Comment by wizjany

the entire region group flag system is fundamentally backwards at the moment and is on our list of things to rework

commented

Comment by sk89q

Finally fixed.