AE2 Unofficial Extended Life

AE2 Unofficial Extended Life

3M Downloads

ME-IO port stacked components cause item or fluid duplication

KasumiNova opened this issue · 0 comments

commented

Describe the bug
The ME-IO port can cause item or fluid replication problems.

To Reproduce
Put several identical storage components in the ME-IO port (Can be empty components or can hold items, but must be NBT identical).
Place these components in the ME-IO port and set the port to the mode of the incoming component.
Before

Deposit any item into the ME network, at which point the item will be transferred to a component within the ME-IO port.
The expected behavior should be to write to only one slot of the component, but the stackable nature results in data being written to multiple components.
Additional description: 64x items were expected to be written, but 128x items were actually written because the 2 components were stacked.
After

Expected behavior
This can result in items or fluids in the network being able to be copied at will, causing serious problems.

Additional context
Code segments that may cause problems:
https://github.com/PrototypeTrousers/Applied-Energistics-2/blob/AE2-Omnifactory/src/main/java/appeng/tile/storage/TileIOPort.java#L77
https://github.com/PrototypeTrousers/Applied-Energistics-2/blob/AE2-Omnifactory/src/main/java/appeng/tile/storage/TileIOPort.java#L78
Limiting the number of stacks to 1 may fix this issue.

Environment

  • Minecraft Version: 1.12.2
  • AE2 Version: v0.54.17
  • Forge Version: 14.23.5.2860