
Soft Crash whenever attempting an autocrafting order from an Arcane Crafting Terminal
thegenghistkhan opened this issue · 8 comments
Describe the bug
Whenever I attempt to put through an autocrafting order from an arcane crafting terminal, my game soft crashes. The prompt to select the number of items to autocraft pops up, but when I hit next, the game soft crashes before the next prompt showing the items to be crafted shows up.
To Reproduce
- Open arcane crafting terminal
- Select an item to autocraft
- Select any quantity and hit next
- Game then soft crashes
Expected behavior
The next prompt showing the "items to be crafted" and then clicking the start button.
Crashlog: https://mclo.gs/Y2XPEgT
Environment
Minecraft: 1.12.2
Forge: Mod Loader: 8.0.99.99
Applied Energistics: AE2 Unofficial Extended Life v0.56.4
Thaumcraft: 6.1.BETA26
Thaumic Energistics: 2.2.7
Modpack: The 1.12.2 Pack
- Minecraft Version:
- AE2 Version: AE2 Unofficial Extended Life v0.56.4
- Forge Version: 14.23.5.2860
@thegenghistkhan Compatibility patch submitted to Thaumic Energistics Extended Life
Related PR: Delfayne/ThaumicEnergistics#34
@NotMyWing After investigation, the bug is caused by the change of the instance referenced by Thaumic Energistics. The original one is GuiNumberBox, and now it is GuiTextField. I have submitted a fix patch to the mod, changing its reference to GuiTextField. It is recommended to provide a compatible solution to the original class. However, after the compatible application, the patch I submitted may need to be reverted.
This is due to the way ThE reaches into the number box to get the crafting amount. I've already been looking at a fix this morning, so I wouldn't worry too much. Actually your fix already builds on top of a change I made in the same area to fix something else. The previously released code would still have failed here, though slightly differently.
What this means is that 0.56.0+ will break previous versions of ThE when trying to craft arcane items. Since we'll have a fix out, this might be "fine", but you may want to doc it.
A compatible fix would probably be to let ThE reach into GuiCraftAmount#amountToCraft
(with an accessor method) so we don't have to use reflection/mixin it. Better yet, extract the logic from actionPerformed
that parses the expression, then we'll use that.
This is due to the way ThE reaches into the number box to get the crafting amount. I've already been looking at a fix this morning, so I wouldn't worry too much. Actually your fix already builds on top of a change I made in the same area to fix something else. The previously released code would still have failed here, though slightly differently.
What this means is that 0.56.0+ will break previous versions of ThE when trying to craft arcane items. Since we'll have a fix out, this might be "fine", but you may want to doc it.
A compatible fix would probably be to let ThE reach into
GuiCraftAmount#amountToCraft
(with an accessor method) so we don't have to use reflection/mixin it. Better yet, extract the logic fromactionPerformed
that parses the expression, then we'll use that.
What failed? I tested it locally and found that the automatic crafting function has actually been fixed. However, this method is a bit crude. Because the one obtained by ThE is only modified based on the new version of the instance.
Sorry, my English is not my native language, this is a message using Google Translate, it may look a bit strange
@Delfayne Funny thing by the way, I actually don't know how to play Thaumcraft at all. During this period, I spent more than ten minutes on how to use the automatic crafting function of ThE, and finally, I found it
commands provided by Tc to unlock all knowledge. I finally got the chance to fix it
I have created a build with fixes for this and others. Please let me know if there are any issues. I will push out to CF at the weekend https://github.com/Delfayne/ThaumicEnergistics/releases/tag/v2.3.0
@Delfayne Simple test, crash has been fixed, complex test needs to wait for other players