AE2 Unofficial Extended Life

AE2 Unofficial Extended Life

3M Downloads

PatternHelper are changed by lock crafting.

Forever-178 opened this issue · 4 comments

commented

Describe the bug

PatternHelper will be changed when crafting results return network in lock crafting mode.

unlockStack.setStackSize(remainingAmount);

Because method getPrimaryOutput return the reference but copy. I recommend use unlockStack = pattern.getPrimaryOutput().copy(); in line 1164.
@zeng-github01

unlockStack = pattern.getPrimaryOutput();

To Reproduce

  1. Build a simple me network and create a pattern with output item greater than 1.
  2. Submit this craft job and return result items one by one.
  3. Submit the craft job again. Crafting plan provides wrong statistic and me interface's unlockStack has wrong item count.

Additional context
ME network
2024-12-17_00 43 27

Pattern and me interface
2024-12-17_00 43 33

Wrong crafting plan
2024-12-17_00 44 38

Other things
At first craft job, craft complete notice are show when first item insert to interface. It should be show after all item returns.

commented

I see,i will fix it ASAP

I first learned C#, and I forgot that the two handle references differently. sorry

commented

Fixed

commented

Fixed in #507.

commented

@NotMyWing This issue is not closed with the PR