AE2 Unofficial Extended Life

AE2 Unofficial Extended Life

3M Downloads

Annihilation Plane no longer accepts drops

zeng-github01 opened this issue · 1 comments

commented

Describe the bug

After #510 Annihilation Plane will no longer accept drops under certain circumstances.

To Reproduce

Use a formation plane to throw out redstone and place obsidian. Use a clicker to make flux dust. The annihilation plane will absorb obsidian but not flux dust.

Expected behavior

Prior to this patch, Annihilation Plane would accept both

Additional context

Environment

  • Minecraft Version:
  • AE2 Version:
  • Forge Version:
commented

@NotMyWing I reviewed #510 and found that I accidentally deleted the logic code for the plane to get the surrounding drops when destroying blocks. This is the reason for this issue. I will improve this issue when I have time.

When I looked up the enchantment implementation, I realized that it was actually manually generating drops, such as fortune. The native function provided by Forge can only get what items will be obtained from this destruction.

We need to generate the dropped items by ourselves through related functions

In #510, I chose to insert the mining results directly into AE. This led to this problem.

This is a bad implementation because it may cause incorrect behavior due to exceptions.